Fix container overriding output-dir/outputs #486
+29
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure we are setting
GUIDELLM_OUTPUT_DIRrather thanGUIDELLM_OUTPUT_PATHin the container to allow--output-dirand--outputsto function. Additionally add a warning when environment variable are set.Details
The container image sets
GUIDELLM_OUTPUT_PATH=/results. Due to the way output-path interacts with the new output-dir and outputs options, output-path overrules their settings.Test Plan
--output-dir /test/path --outputs test.json,test.csvRelated Issues
Use of AI
## WRITTEN BY AI ##)