Skip to content

Conversation

@sjmonson
Copy link
Collaborator

@sjmonson sjmonson commented Nov 25, 2025

Summary

Ensure we are setting GUIDELLM_OUTPUT_DIR rather than GUIDELLM_OUTPUT_PATH in the container to allow --output-dir and --outputs to function. Additionally add a warning when environment variable are set.

Details

The container image sets GUIDELLM_OUTPUT_PATH=/results. Due to the way output-path interacts with the new output-dir and outputs options, output-path overrules their settings.

Test Plan

  • Run container with --output-dir /test/path --outputs test.json,test.csv

Related Issues

  • Resolves #

  • "I certify that all code in this PR is my own, except as noted below."

Use of AI

  • Includes AI-assisted code completion
  • Includes code generated by an AI application
  • Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes ## WRITTEN BY AI ##)

@sjmonson sjmonson force-pushed the fix/container_out_dir branch from 0bcb18c to 91732e0 Compare November 25, 2025 18:28
@sjmonson sjmonson added this to the v0.4.1 milestone Nov 25, 2025
@sjmonson sjmonson force-pushed the fix/container_out_dir branch from c9270a9 to 78460f6 Compare November 25, 2025 19:23
@sjmonson sjmonson force-pushed the fix/container_out_dir branch from 78460f6 to 23ee5b6 Compare November 25, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants