Refactor CSV tests#715
Merged
jaredoconnell merged 2 commits intovllm-project:mainfrom May 5, 2026
Merged
Conversation
dbutenhof
previously approved these changes
May 4, 2026
Collaborator
dbutenhof
left a comment
dbutenhof
left a comment
There was a problem hiding this comment.
I like the cleaner set of test cases...
dbutenhof
approved these changes
May 5, 2026
It now isolates specific functionality better, and covers more edge cases. Assisted-by: Cursor AI Signed-off-by: Jared O'Connell <joconnel@redhat.com>
Signed-off-by: Jared O'Connell <joconnel@redhat.com>
jaredoconnell
force-pushed
the
refactor/csv-improvements
branch
from
a0ad0c1 to
b8dc13f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It now isolates specific functionality better, and covers more edge cases.
Details
_align_columns, which can be more easily tested in isolation.Test Plan
Use of AI
## WRITTEN BY AI ##)