Skip to content

Conversation

@sugatmahanti
Copy link
Contributor

SUMMARY:
This is part of #1927

Modernize type annotations using | operator and built-in generics in the transformer module as part of codebase modernization effort.

TEST PLAN:

make style
make quality
make tests

Notes:
Happy to address any comments! Thank you!

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sugatmahanti, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing the codebase by updating Python type annotations within the transformers module. The changes primarily involve adopting the | operator for union and optional types and utilizing built-in generic types, which enhances code clarity and aligns with contemporary Python typing standards. This systematic update contributes to a more maintainable and readable codebase.

Highlights

  • Type Hint Modernization: Updated type annotations across the transformers module to use the more modern | operator for Union and Optional types, replacing older syntax like Optional[Type] with Type | None.
  • Built-in Generic Types: Replaced generic type annotations from the typing module (e.g., List[Type], Dict[Key, Value]) with their built-in counterparts (e.g., list[Type], dict[Key, Value]) for improved readability and consistency.
  • Cleanup of typing Imports: Removed unnecessary imports from the typing module in various files, as many of the replaced type hints no longer require explicit imports.
  • Minor Typo Correction: Corrected a small typo in sparsity_metadata_config.py, changing 'dedue' to 'deduce'.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully modernizes the type annotations across several Python files within the transformers module. It consistently replaces typing.Optional[Type] with Type | None and typing.Union[Type1, Type2] with Type1 | Type2, as well as typing.List and typing.Dict with built-in list and dict generics. This change improves code readability and leverages newer Python syntax for type hinting. A minor typo (dedue to deduce) was also corrected. The changes are well-aligned with the stated goal of codebase modernization.

@@ -1,5 +1,5 @@
from collections import defaultdict
from typing import Dict, List, Optional, Tuple
from typing import Tuple
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be removed as well, using built-in tuple instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I will do that. Thanks

)

def _calculate_checkpoint_info(self, kwargs) -> Tuple[Optional[str], float]:
def _calculate_checkpoint_info(self, kwargs) -> Tuple[str | None, float]:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too

Suggested change
def _calculate_checkpoint_info(self, kwargs) -> Tuple[str | None, float]:
def _calculate_checkpoint_info(self, kwargs) -> tuple[str | None, float]:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants