-
Notifications
You must be signed in to change notification settings - Fork 288
Modernize transformers module with type hints and generic types #2034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Modernize transformers module with type hints and generic types #2034
Conversation
Summary of ChangesHello @sugatmahanti, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on modernizing the codebase by updating Python type annotations within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request successfully modernizes the type annotations across several Python files within the transformers module. It consistently replaces typing.Optional[Type] with Type | None and typing.Union[Type1, Type2] with Type1 | Type2, as well as typing.List and typing.Dict with built-in list and dict generics. This change improves code readability and leverages newer Python syntax for type hinting. A minor typo (dedue to deduce) was also corrected. The changes are well-aligned with the stated goal of codebase modernization.
| @@ -1,5 +1,5 @@ | |||
| from collections import defaultdict | |||
| from typing import Dict, List, Optional, Tuple | |||
| from typing import Tuple | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be removed as well, using built-in tuple instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I will do that. Thanks
| ) | ||
|
|
||
| def _calculate_checkpoint_info(self, kwargs) -> Tuple[Optional[str], float]: | ||
| def _calculate_checkpoint_info(self, kwargs) -> Tuple[str | None, float]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here too
| def _calculate_checkpoint_info(self, kwargs) -> Tuple[str | None, float]: | |
| def _calculate_checkpoint_info(self, kwargs) -> tuple[str | None, float]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will change.
SUMMARY:
This is part of #1927
Modernize type annotations using | operator and built-in generics in the transformer module as part of codebase modernization effort.
TEST PLAN:
Notes:
Happy to address any comments! Thank you!