Skip to content

Conversation

@Lumosis
Copy link
Collaborator

@Lumosis Lumosis commented Oct 22, 2025

Description

Pre-compilation PR will come later.
Next step: avoid waiting for TPU->CPU transfer,

Tests

UTs tested.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@Lumosis Lumosis requested a review from py4 October 22, 2025 06:41
@github-actions
Copy link

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

Copy link
Collaborator

@py4 py4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if a jitted function is only used within another jitted function, where is no point in marking that function as jitted as things get inlined anyway

Signed-off-by: Lihao Ran <[email protected]>
Copy link
Collaborator

@py4 py4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the acceptance rate issue to make sure we are not introducing regression

Signed-off-by: Lihao Ran <[email protected]>
Signed-off-by: Lihao Ran <[email protected]>
@py4
Copy link
Collaborator

py4 commented Oct 24, 2025

Can we also rename some of these functions? We have so many prepare_inputs_" names. It's a bit difficult to understand what's the difference between prepare_inputsandprepare_inputs_in_jit` for instance. Can we come up with more concrete names? if that makes sense

@Lumosis
Copy link
Collaborator Author

Lumosis commented Oct 25, 2025

Can we also rename some of these functions? We have so many prepare_inputs_" names. It's a bit difficult to understand what's the difference between prepare_inputsandprepare_inputs_in_jit` for instance. Can we come up with more concrete names? if that makes sense

Done

Signed-off-by: Lihao Ran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants