-
Couldn't load subscription status.
- Fork 18
[Spec Decoding] Merge jitted helpers for eagle3 #920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Lihao Ran <[email protected]>
DescriptionStart with a short description of what the PR does and how this is a change from The rest of the description includes relevant details and context, examples:
If the change fixes a bug or a Github issue, please include a link, e.g.,: TestsPlease describe how you tested this change, and include any instructions and/or ChecklistBefore submitting this PR, please make sure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if a jitted function is only used within another jitted function, where is no point in marking that function as jitted as things get inlined anyway
Signed-off-by: Lihao Ran <[email protected]>
Signed-off-by: Lihao Ran <[email protected]>
Signed-off-by: Lihao Ran <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix the acceptance rate issue to make sure we are not introducing regression
Signed-off-by: Lihao Ran <[email protected]>
Signed-off-by: Lihao Ran <[email protected]>
|
Can we also rename some of these functions? We have so many |
Done |
Signed-off-by: Lihao Ran <[email protected]>
Description
Pre-compilation PR will come later.
Next step: avoid waiting for TPU->CPU transfer,
Tests
UTs tested.
Checklist
Before submitting this PR, please make sure: