Skip to content

Conversation

@hfan
Copy link
Collaborator

@hfan hfan commented Oct 24, 2025

Description

The mock object breaks the test when the vllm code tries to use it.

Tests

Ran the failure test: pytest -v tests/worker/tpu_worker_jax_test.py::TestTPUWorker::test_init_device_with_provided_devices

CI: https://buildkite.com/tpu-commons/tpu-inference-ci/builds/4606#019a16b6-9bf8-4dc5-81d5-97d6bc35791a

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@github-actions
Copy link

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@hfan hfan merged commit 8b1e8e7 into main Oct 24, 2025
3 checks passed
@hfan hfan deleted the hfan_fix_ci branch October 24, 2025 15:55
sierraisland pushed a commit that referenced this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants