Skip to content

Conversation

@toolsmanhehe
Copy link

@toolsmanhehe toolsmanhehe commented Oct 23, 2025

What this PR does / why we need it?

When we install vllm-ascend in a non-pure environment, the project may not run as expected due to interference from older versions.

Does this PR introduce any user-facing change?

It merely adds relevant installation tips.

How was this patch tested?

I tested the installation steps in a non-pure environment on GitCode and found this issue.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the installation documentation to help users avoid issues with previous installations and to clarify expected runtime messages. The changes are helpful, but there are a few areas where the wording can be improved for clarity and correctness. I've suggested changes to correct an erroneous package name and to rephrase some comments in a code block to be more direct and grammatically correct. These improvements should help prevent user confusion during the setup process.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant