[Refactor] Refactor Ascend attention implementation forward #3674
+113
−263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR refactors the Ascend attention implementation to align with vLLM's core interfaces, simplifying the code and improving maintainability.
Key Changes:
Align with vLLM's Attention Interface: The
forwardmethod signature inAscendAttentionBackendImplnow matches the baseAttentionImplin vLLM, removing the customtrace_flag.Enable Opaque Attention Operator: By adding
opaque_attention_optoAscendPlatform, we allow vLLM to wrap our attention kernel in its standardvllm.unified_attention_with_outputoperator. This avoids the need for a custom call path.Remove Obsolete Code:
vllm.unified_ascend_attention_with_outputhas been deleted as it is now redundant.trace_flagand its associated logic were removed, reducing code complexity.Improve Readability: Renamed output variables (
outputvs.intermediate_output) and added comments to clarify the in-place nature of the attention output.Does this PR introduce any user-facing change?
None.
How was this patch tested?
No extra tests needed.