Skip to content

Conversation

@gcanlin
Copy link
Contributor

@gcanlin gcanlin commented Oct 27, 2025

What this PR does / why we need it?

As a validation for #3664, add end-to-end tests to monitor the InternVL model and ensure its continuous proper operation. This PR is only for single-card. So the models that have more parameters than 8B like 78B are needed to test using multi-cards.

Does this PR introduce any user-facing change?

None.

How was this patch tested?

pytest -sv tests/e2e/singlecard/multi-modal/test_internvl.py

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds end-to-end tests for the InternVL model family, which is a good validation for the related changes. The test covers several models and correctly verifies the consistency between eager and graph execution modes. I've found a significant amount of duplicated code in the test logic for the two modes. I've suggested a refactoring to improve maintainability by removing this duplication.

@gcanlin
Copy link
Contributor Author

gcanlin commented Oct 29, 2025

@wangxiyuan InternVL2-8B and InternVL2_5-8B still have 27,985 and 8,270 downloads last month in huggingface. I think we should keep them in the e2e tests.
@MengqingCao The outputs of InternVL3_5-8B with eager mode and ACL graph mode equal exactly now. Don't know the reason lead to different and can't reproduce it. So remove check_outputs_similar now.
Please take a look again. Thanks!

Signed-off-by: gcanlin <[email protected]>
Signed-off-by: gcanlin <[email protected]>
@wangxiyuan wangxiyuan merged commit f99762e into vllm-project:main Oct 31, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:tests ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants