Skip to content

Conversation

@LookAround0301
Copy link
Contributor

@LookAround0301 LookAround0301 commented Nov 12, 2025

What this PR does / why we need it?

1、qwen GQA attention_v1 optim
2、DeepSeek MLA refactor, all gather q -> all gather kv
3、modelrunner refactor for chunk prefill, we remove some code not use

Does this PR introduce any user-facing change?

How was this patch tested?

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the chunked prefill implementation for MLA attention to better support context parallelism (PCP/DCP). The changes simplify the logic in _compute_prefill_context by introducing a new helper function _reorg_kvcache and unifying the handling of different parallelism configurations. While the refactoring in vllm_ascend/attention/mla_v1.py is a significant improvement in code clarity and maintainability, I've identified a critical bug in vllm_ascend/worker/model_runner_v1.py related to the calculation of context length for speculative decoding when context parallelism is enabled. This could lead to incorrect attention computations.

@wangxiyuan wangxiyuan added the ready read for review label Nov 13, 2025
@wangxiyuan
Copy link
Collaborator

I'll enable full test once lint pass

Signed-off-by: LookAround <[email protected]>
Delphine-Nic and others added 2 commits November 13, 2025 16:56
Signed-off-by: Delphine-Nic <[email protected]>
Signed-off-by: LookAround <[email protected]>
@wangxiyuan wangxiyuan added the ready-for-test start test by label for PR label Nov 13, 2025
Signed-off-by: LookAround <[email protected]>
@wangxiyuan wangxiyuan merged commit 5ec96fd into vllm-project:main Nov 14, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:tests ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants