Skip to content

Conversation

@wangxiaochao6
Copy link
Contributor

@wangxiaochao6 wangxiaochao6 commented Nov 13, 2025

add feature for Mooncake_connector supporting pcp/dcp

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for prefill context parallelism (pcp) and decode context parallelism (dcp) to the Mooncake connector. The changes correctly update parallelism parameters, port calculations, and data structures to handle these new parallelism dimensions. However, I've identified a few critical issues: an incorrect type hint in ReqMeta that will lead to a TypeError, and two separate bugs in the new _get_kv_split_metadata function that will cause incorrect behavior and likely runtime errors when transferring KV caches in pcp/dcp scenarios. These issues need to be addressed to ensure the feature works as intended.

@LCAIZJ
Copy link
Contributor

LCAIZJ commented Nov 14, 2025

Noted. I'll monitor this PR for updates.

@wangxiyuan
Copy link
Collaborator

@LCAIZJ Please double check this one. Thanks

@LCAIZJ
Copy link
Contributor

LCAIZJ commented Nov 16, 2025

@LCAIZJ Please double check this one. Thanks

On it! I'll review and provide feedback shortly.

Signed-off-by: wangxiaochao <[email protected]>
@wangxiyuan
Copy link
Collaborator

@LCAIZJ @liziyu179 Please approve this, then I'll merge it.

@liziyu179
Copy link
Contributor

it's look good to me

@LCAIZJ
Copy link
Contributor

LCAIZJ commented Nov 18, 2025

@LCAIZJ @liziyu179 Please approve this, then I'll merge it.

done

@wangxiyuan wangxiyuan merged commit 0d04ad8 into vllm-project:main Nov 18, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants