-
Notifications
You must be signed in to change notification settings - Fork 574
[feature] Mooncake_connector support pcp/dcp #4183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for prefill context parallelism (pcp) and decode context parallelism (dcp) to the Mooncake connector. The changes correctly update parallelism parameters, port calculations, and data structures to handle these new parallelism dimensions. However, I've identified a few critical issues: an incorrect type hint in ReqMeta that will lead to a TypeError, and two separate bugs in the new _get_kv_split_metadata function that will cause incorrect behavior and likely runtime errors when transferring KV caches in pcp/dcp scenarios. These issues need to be addressed to ensure the feature works as intended.
|
Noted. I'll monitor this PR for updates. |
|
@LCAIZJ Please double check this one. Thanks |
On it! I'll review and provide feedback shortly. |
cd95149 to
e935ae3
Compare
Signed-off-by: wangxiaochao <[email protected]>
Signed-off-by: wangxiaochao <[email protected]>
|
@LCAIZJ @liziyu179 Please approve this, then I'll merge it. |
|
it's look good to me |
done |
add feature for Mooncake_connector supporting pcp/dcp