Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0/N] Rename MultiModalInputs to MultiModalKwargs #10040

Merged
merged 5 commits into from
Nov 9, 2024
Merged

[0/N] Rename MultiModalInputs to MultiModalKwargs #10040

merged 5 commits into from
Nov 9, 2024
+151 −121

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Nov 5, 2024 •
edited
Loading

The current MultiModalInputs is similar in name to the other *Inputs structures under vllm.inputs but takes a quite different meaning, as the former is designed to be passed directly to the model while the latter is designed to be passed to vllm.sequence.Sequence. To avoid confusion, I have renamed MultiModalInputs to MultiModalKwargs.

Part of #10114

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Nov 5, 2024
@DarkLight1337 DarkLight1337 mentioned this pull request Nov 5, 2024
Merged
@mergify Mergify
Copy link

mergify bot commented Nov 6, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. @DarkLight1337 please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Nov 6, 2024
@mergify mergify bot removed the needs-rebase label Nov 6, 2024
@DarkLight1337 DarkLight1337 mentioned this pull request Nov 7, 2024
Open
6 tasks
@mergify Mergify
Copy link

mergify bot commented Nov 8, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @DarkLight1337.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Nov 8, 2024
@mergify mergify bot removed the needs-rebase label Nov 8, 2024
@DarkLight1337 DarkLight1337 merged commit e0191a9 into main Nov 9, 2024
51 checks passed
@DarkLight1337 DarkLight1337 deleted the rename-mm-inputs branch November 9, 2024 03:31
@DarkLight1337 DarkLight1337 mentioned this pull request Nov 9, 2024
Open
84 tasks
omer-dayan pushed a commit to omer-dayan/vllm that referenced this pull request Nov 10, 2024
@DarkLight1337 @omer-dayan
[0/N] Rename MultiModalInputs to MultiModalKwargs (vllm-project#1…
dc767ea 
…0040)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: OmerD <[email protected]>
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
@DarkLight1337 @JC1DA
[0/N] Rename MultiModalInputs to MultiModalKwargs (vllm-project#1…
1513f22 
…0040)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Loc Huynh <[email protected]>
jeejeelee pushed a commit to jeejeelee/vllm that referenced this pull request Nov 11, 2024
@DarkLight1337 @jeejeelee
[0/N] Rename MultiModalInputs to MultiModalKwargs (vllm-project#1…
cc619a5 
…0040)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
rickyyx pushed a commit to rickyyx/vllm that referenced this pull request Nov 13, 2024
@DarkLight1337 @rickyyx
[0/N] Rename MultiModalInputs to MultiModalKwargs (vllm-project#1…
7247c9f 
…0040)

Signed-off-by: DarkLight1337 <[email protected]>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@DarkLight1337 @sumitd2
[0/N] Rename MultiModalInputs to MultiModalKwargs (vllm-project#1…
4b724d8 
…0040)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic Awaiting requested review from robertgshaw2-neuralmagic

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarkLight1337 @Isotr0py