fix(utils): handle WinError 11 in process_lock._is_pid_alive#854
Merged
qin-ctx merged 2 commits intovolcengine:mainfrom Mar 22, 2026
Merged
Conversation
On Windows, os.kill(pid, 0) can raise OSError with WinError 11 (ERROR_BAD_FORMAT) in addition to WinError 87 for stale/invalid PIDs. The previous catch-all OSError handler also silently swallowed errors on non-Windows platforms. This change: - Documents both known WinError codes (11, 87) in the comment - Restricts the broad OSError catch to Windows only (re-raises on other platforms to avoid masking real errors) Fixes volcengine#842 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Failed to generate code suggestions for PR |
qin-ctx
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #842. On Windows 11,
os.kill(pid, 0)can raiseOSErrorwithWinError 11(ERROR_BAD_FORMAT) for stale PIDs, in addition to the already-knownWinError 87. This causes the server to crash on startup when a stale lock file exists.OSErroron Windows only (sys.platform == "win32") and returnsFalse(pid not alive)OSErroron non-Windows platforms to preserve existing behaviorTest plan
OSError