feat!: breaking API batch — v2.1.0 (#63 #64 #65 #66) - #121
Merged
Conversation
#66) BREAKING: ArbitrageReport.is_free is now a computed method, not a stored field. ArbitrageReport gains expiry: f64 field. merge() removed (was only used in tests). clean() now takes expiry parameter. Serde output no longer includes is_free (derivable from violations).
BREAKING: SurfaceDiagnostics.is_free is now a computed method. Serde output no longer includes is_free. Computed from smile_reports and calendar_violations, matching the logic previously duplicated at every construction site.
BREAKING: SmileSection gains required model_name() method returning &'static str. Returns "SVI", "SABR", "CubicSpline", "SSVI", "eSSVI".
BREAKING: VolSurface gains required tenors() method returning &[f64]. Enables generic code over Box<dyn VolSurface> to discover tenor grid.
Breaking API changes in this release: - ArbitrageReport: is_free is computed, expiry field added, merge() removed - SurfaceDiagnostics: is_free is computed - SmileSection: model_name() added - VolSurface: tenors() added
Address roborev review gaps: model_name on SVI/SABR, expiry getter, tenors on PiecewiseSurface, stronger serde assertion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batched all 4 remaining breaking API changes into a single release (v2.1.0).
Breaking Changes
is_freeis now a computed method (not stored field). Newexpiry: f64field.merge()removed.clean()takes expiry param. Serde output no longer includesis_free.is_freeis now a computed method. Logic consolidated from 3 duplicate sites.model_name() -> &'static strmethod. Returns "SVI", "SABR", "CubicSpline", "SSVI", "eSSVI".tenors() -> &[f64]method. Enables generic code overBox<dyn VolSurface>.Semver Note
v2.1.0 (pragmatic) — 0 downstream crates on crates.io. Breaking changes documented in commit messages with
feat!:prefix.Changes
Test plan
Closes #63, closes #64, closes #65, closes #66