Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run
clippy lint
as part of CI, and Rust has introduced a number of lints since we last updated our Rust version. It is not clear to me why these did not fail on #1611, but they immediately started causing issues for all PRs once that was merged. This PR resolves all outstanding Clippy lints, in most cases with very simple mechanical transformations. The vast majority of those are removing references in contexts where they have become redundant courtesy of improvements to the borrow checker (all dating back to Rust 2021, if I recall correctly.) The only “interesting” change is in 12976b2, which reworks one loop in test support from a loop with the actual functionality in the condition for awhile let
binding to usingloop
with an explicitbreak
instead.