Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all recent Clippy lints #1638

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Fix all recent Clippy lints #1638

merged 2 commits into from
Jan 10, 2024

Conversation

chriskrycho
Copy link
Contributor

We run clippy lint as part of CI, and Rust has introduced a number of lints since we last updated our Rust version. It is not clear to me why these did not fail on #1611, but they immediately started causing issues for all PRs once that was merged. This PR resolves all outstanding Clippy lints, in most cases with very simple mechanical transformations. The vast majority of those are removing references in contexts where they have become redundant courtesy of improvements to the borrow checker (all dating back to Rust 2021, if I recall correctly.) The only “interesting” change is in 12976b2, which reworks one loop in test support from a loop with the actual functionality in the condition for a while let binding to using loop with an explicit break instead.

@chriskrycho
Copy link
Contributor Author

chriskrycho commented Jan 10, 2024

Looks like I need to tweak the semantics of that loop slightly. Will do that tomorrow! The problem was white space in the output from the human-formatted list commands. We should think about using some variety of snapshot testing for those, perhaps.

@chriskrycho chriskrycho merged commit e48ab1f into main Jan 10, 2024
11 checks passed
@chriskrycho chriskrycho deleted the fix-lints branch January 10, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant