Replace DynVarBinBuilder with VarBinBuilder being an actual builder and optimise append_to_builder for string/binary compressed arrays - #9030
Closed
robert3005 wants to merge 3 commits into
Closed
Conversation
robert3005
added
changelog/chore
robert3005
marked this pull request as draft
July 28, 2026 13:13
…nd optimise append_to_builder for string/binary compressed arrays Signed-off-by: Robert Kruszewski <github@robertk.io>
robert3005
force-pushed
the
rk/onevarbinbuilder
branch
from
July 29, 2026 00:17
4eca459 to
aa487d8
Compare
robert3005
marked this pull request as ready for review
July 29, 2026 00:18
Signed-off-by: Robert Kruszewski <github@robertk.io>
robert3005
commented
Jul 29, 2026
Comment on lines
+50
to
+54
| /// This is the offset-based counterpart to | ||
| /// [`VarBinViewBuilder`](crate::builders::VarBinViewBuilder): values are laid out contiguously in | ||
| /// a single byte buffer described by a monotonically increasing offsets buffer. An `i32` or `i64` | ||
| /// builder can therefore be handed straight to Arrow as a `Utf8`/`LargeUtf8`/`Binary`/ | ||
| /// `LargeBinary` array without re-laying out the bytes. |
Contributor
Author
|
replaced with a stack starting at #9096 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need two constructs, the overall flow of appending to builder could
have been optimised