Dict: gather dictionary values straight into a VarBinBuilder - #9098
Open
robert3005 wants to merge 4 commits into
Open
Dict: gather dictionary values straight into a VarBinBuilder#9098robert3005 wants to merge 4 commits into
robert3005 wants to merge 4 commits into
Conversation
robert3005
commented
Jul 31, 2026
robert3005
marked this pull request as ready for review
July 31, 2026 13:42
robert3005
force-pushed
the
rk/dict-gather-into-builder
branch
from
July 31, 2026 18:11
91142df to
c82aa58
Compare
Merging this PR will improve performance by 10.35%
Performance Changes
Tip Curious why this is faster? Comment Comparing 
Footnotes
|
robert3005
force-pushed
the
rk/dict-gather-into-builder
branch
from
August 4, 2026 12:46
c82aa58 to
e3cd801
Compare
robert3005
commented
Aug 4, 2026
| /// | ||
| /// This is a handful of enum discriminant checks over the array's buffer handles, so it stays | ||
| /// outside the per-row loop and costs nothing measurable on the host-resident path. | ||
| fn varbin_fast_path_is_host(codes: &PrimitiveArray, values: &VarBinViewArray) -> bool { |
Contributor
Author
There was a problem hiding this comment.
we don't care about this check, it's guarded elsewhere
robert3005
commented
Aug 4, 2026
| /// | ||
| /// A code pointing at a null dictionary entry produces a null row, matching what | ||
| /// [`take_canonical`] derives from [`Validity::take`](crate::validity::Validity::take). | ||
| fn dict_validity<C: IntegerPType>( |
Contributor
Author
There was a problem hiding this comment.
this is just the validity of the array
Appending a string dictionary to a builder went through `take_canonical`, which first materializes the values at full logical length — allocating and re-reading a views buffer proportional to the row count. The dictionary is usually far smaller than the column, so resolving each code against it in place skips that intermediate and leaves one `memcpy` per row. The fast path indexes the codes and the dictionary's views and data buffers as host slices, so `varbin_fast_path_is_host` gates it on residency; a device-resident dictionary still takes the canonical route, where a device kernel can serve it. Signed-off-by: Robert Kruszewski <robert@spiraldb.com> Signed-off-by: Robert Kruszewski <github@robertk.io>
robert3005
force-pushed
the
rk/dict-gather-into-builder
branch
from
August 4, 2026 23:14
ef964a6 to
bc69d12
Compare
onursatici
reviewed
Aug 5, 2026
| /// than the column, so resolving each code against it in place skips that intermediate entirely | ||
| /// and leaves one `memcpy` per row as the only work. | ||
| /// | ||
| /// The caller must have checked [`varbin_fast_path_is_host`]; this function indexes the backing |
Contributor
There was a problem hiding this comment.
does this still exist? Without asserting this we would panic for arrays with device buffers below
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Materialize dictionary values straight into VarBinBuilder instead of copying