Skip to content

Add Map compute and compression support - #9110

Open
AdamGS wants to merge 2 commits into
developfrom
adamg/maptype-3
Open

Add Map compute and compression support#9110
AdamGS wants to merge 2 commits into
developfrom
adamg/maptype-3

Conversation

@AdamGS

@AdamGS AdamGS commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Rationale for this change

  • Closes: #000

What changes are included in this PR?

What APIs are changed? Are there any user-facing changes?

@codspeed-hq

codspeed-hq Bot commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will improve performance by 13.3%

⚡ 1 improved benchmark
✅ 1841 untouched benchmarks
⏩ 44 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Simulation chunked_varbinview_opt_into_canonical[(10, 1000)] 6.2 ms 5.5 ms +13.3%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

Comparing adamg/maptype-3 (acbb54f) with develop (85569a2)

Open in CodSpeed

Footnotes

  1. 44 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@AdamGS AdamGS added the changelog/feature A new feature label Jul 31, 2026
@AdamGS
AdamGS force-pushed the adamg/maptype-3 branch from 0080a74 to ded0750 Compare July 31, 2026 11:40
@AdamGS
AdamGS force-pushed the adamg/maptype-3 branch from ded0750 to 289bf71 Compare July 31, 2026 11:52
@AdamGS
AdamGS force-pushed the adamg/maptype-3 branch from 289bf71 to f191760 Compare July 31, 2026 12:09
@AdamGS
AdamGS force-pushed the adamg/maptype-3 branch from f191760 to 0fd842d Compare July 31, 2026 13:17
robert3005
robert3005 reviewed Aug 4, 2026
View reviewed changes
Comment thread vortex-array/src/arrays/map/compute/mod.rs Outdated

fn rebuild_map_from_array(map_dtype: MapDType, entries: ArrayRef) -> VortexResult<ArrayRef> {
let entries = entries
.as_opt::<ListView>()

@robert3005 robert3005 Aug 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's downcast instead of this

@AdamGS
AdamGS marked this pull request as ready for review August 4, 2026 14:50
Base automatically changed from adamg/maptype-2 to develop August 4, 2026 15:29
@connortsui20

connortsui20 commented Aug 4, 2026

Copy link
Copy Markdown
Member

Will this close #9181?

We probably shouldn't be adding things to the fuzzer until they are mostly done

AdamGS added 2 commits August 5, 2026 12:04
@AdamGS
Add Map compute and compression support
367e666 
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS
better slots fix
acbb54f 
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robert3005 robert3005 robert3005 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

changelog/feature A new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AdamGS @connortsui20 @robert3005