Use RowIdxLayoutReader only when #row_idx is referenced - #9190
Open
myrrc wants to merge 3 commits into
Open
Conversation
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
myrrc
added
changelog/fix
myrrc
enabled auto-merge (squash)
August 5, 2026 11:12
AdamGS
reviewed
Aug 5, 2026
Merging this PR will not alter performance
Comparing 
Footnotes
|
myrrc
force-pushed
the
myrrc/row-idx-if-used
branch
from
August 5, 2026 13:13
1a53628 to
92bf395
Compare
Contributor
|
Where does this show up? I think we should ensure that the row idx layout reader is fast in this case? |
Contributor
Author
Clickbench queries mostly. I think main goal is to do as little work as possible and not initialize an extra layout reader if we can |
github-actions
Bot
removed
the
action/benchmark-sql
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals Profiling 📖Vortex (geomean): 0.974x ➖ datafusion / vortex-file-compressed / ns (0.974x ➖, 0↑ 0↓)
No file size changes detected. |
Contributor
Benchmarks: TPC-H SF=1 on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (0.973x ➖, 0↑ 0↓)
datafusion / parquet / ns (0.994x ➖, 1↑ 1↓)
duckdb / vortex-file-compressed / ns (1.026x ➖, 0↑ 2↓)
duckdb / parquet / ns (0.995x ➖, 1↑ 0↓)
File Size Changes (9 files changed, -43.9% overall, 0↑ 9↓)
Totals:
|
Contributor
Benchmarks: FineWeb NVMe 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (1.007x ➖, 0↑ 0↓)
datafusion / parquet / ns (1.002x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (1.078x ➖, 0↑ 3↓)
duckdb / parquet / ns (0.991x ➖, 0↑ 0↓)
File Size Changes (2 files changed, -46.3% overall, 0↑ 2↓)
Totals:
|
Contributor
Benchmarks: TPC-DS SF=1 on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (0.987x ➖, 2↑ 1↓)
datafusion / parquet / ns (0.997x ➖, 2↑ 1↓)
duckdb / vortex-file-compressed / ns (0.994x ➖, 4↑ 3↓)
duckdb / parquet / ns (1.001x ➖, 3↑ 5↓)
File Size Changes (25 files changed, -43.5% overall, 0↑ 25↓)
Totals:
|
Contributor
Benchmarks: Clickbench Sorted on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (0.936x ➖, 2↑ 0↓)
datafusion / parquet / ns (1.025x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed / ns (1.020x ➖, 1↑ 1↓)
duckdb / parquet / ns (0.974x ➖, 0↑ 0↓)
File Size Changes (201 files changed, -42.8% overall, 48↑ 153↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=10 on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (0.988x ➖, 1↑ 0↓)
datafusion / parquet / ns (0.995x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (1.013x ➖, 0↑ 0↓)
duckdb / parquet / ns (0.973x ➖, 1↑ 0↓)
File Size Changes (9 files changed, -44.0% overall, 0↑ 9↓)
Totals:
|
Contributor
Benchmarks: Clickbench on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (0.998x ➖, 3↑ 2↓)
datafusion / parquet / ns (1.010x ➖, 0↑ 2↓)
duckdb / vortex-file-compressed / ns (0.994x ➖, 4↑ 3↓)
duckdb / parquet / ns (0.999x ➖, 1↑ 0↓)
File Size Changes (101 files changed, -39.2% overall, 0↑ 101↓)
Totals:
|
Contributor
Benchmarks: Statistical and Population Genetics 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
duckdb / vortex-file-compressed / ns (0.950x ➖, 3↑ 1↓)
duckdb / parquet / ns (0.992x ➖, 0↑ 0↓)
File Size Changes (2 files changed, -32.3% overall, 0↑ 2↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=1 on S3 📖Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (0.979x ➖, 1↑ 2↓)
datafusion / parquet / ns (1.012x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (0.930x ➖, 2↑ 0↓)
duckdb / parquet / ns (0.983x ➖, 0↑ 1↓)
|
Contributor
Benchmarks: FineWeb S3 📖Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (1.166x ➖, 0↑ 2↓)
datafusion / parquet / ns (0.867x ➖, 1↑ 0↓)
duckdb / vortex-file-compressed / ns (0.971x ➖, 0↑ 0↓)
duckdb / parquet / ns (0.798x ➖, 1↑ 0↓)
|
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we wrap layout readers with RowIdxLayoutReader even if it's not used.
This increases CPU usage on requests that don't use it (i.e. clickbench).
The cost of recursive expression iteration is lower than runtime of
RowIdxLayoutReader so it's a net benefit.
Add expression.contains() method which checks expression has another expression inside.