duckdb: convert aggregate results to duckdb requested output type - #9231
Merged
Conversation
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
myrrc
enabled auto-merge (squash)
August 6, 2026 13:06
Merging this PR will degrade performance by 34.16%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
gatesn
reviewed
Aug 6, 2026
robert3005
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duckdb widens output aggregation results to avoid overflow. This means
output column may be i128 even if input scalars are not. Our reference_value
doesn't cast duckdb Value to desired type but reinterprets bits which lead
to undefined behaviour.