Skip to content

duckdb: convert aggregate results to duckdb requested output type - #9231

Merged
myrrc merged 1 commit into
developfrom
myrrc/duckdb-aggregate-output-type
Aug 6, 2026
Merged

duckdb: convert aggregate results to duckdb requested output type#9231
myrrc merged 1 commit into
developfrom
myrrc/duckdb-aggregate-output-type

Conversation

@myrrc

@myrrc myrrc commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Duckdb widens output aggregation results to avoid overflow. This means
output column may be i128 even if input scalars are not. Our reference_value
doesn't cast duckdb Value to desired type but reinterprets bits which lead
to undefined behaviour.

Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc myrrc added changelog/fix A bug fix ext/duckdb Relates to the DuckDB integration labels Aug 6, 2026
@myrrc
myrrc enabled auto-merge (squash) August 6, 2026 13:06
@codspeed-hq

codspeed-hq Bot commented Aug 6, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 34.16%

❌ 2 regressed benchmarks
✅ 1899 untouched benchmarks
⏩ 43 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation decompress[u64, (1000, 16)] 74 µs 134.4 µs -44.94%
Simulation decode_varbin[(1000, 2)] 61.5 µs 78.1 µs -21.25%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing myrrc/duckdb-aggregate-output-type (3b63c0a) with develop (3f83ee9)

Open in CodSpeed

Footnotes

  1. 43 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Comment thread vortex-duckdb/src/table_function.rs
@myrrc
myrrc requested a review from gatesn August 6, 2026 15:18
@myrrc
myrrc merged commit 6ae2a8b into develop Aug 6, 2026
147 of 152 checks passed
@myrrc
myrrc deleted the myrrc/duckdb-aggregate-output-type branch August 6, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix ext/duckdb Relates to the DuckDB integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants