move FileFormat from EGF to ExternalFile#491
Open
jones-liam-j wants to merge 1 commit intovip-2025-proposed-updatesfrom
Open
move FileFormat from EGF to ExternalFile#491jones-liam-j wants to merge 1 commit intovip-2025-proposed-updatesfrom
jones-liam-j wants to merge 1 commit intovip-2025-proposed-updatesfrom
Conversation
A single ExternalFile can't have multiple file formats, right?
Collaborator
|
It looks like it is structured the way it is because the FileFormat is
specifically a geospatial file format; ExternalFile could refer to other
things as well in theory (even though the spec doesn't support any other
types of external files currently). The GeospatialFormat enumeration is,
in turn, shared with CDF, so I don't think we want to generalize it.
…On Wed, Jun 11, 2025 at 11:30 AM Liam Jones ***@***.***> wrote:
This has always confused me. A single ExternalFile can't have multiple
file formats, right?
------------------------------
You can view, comment on, or merge this pull request online at:
#491
Commit Summary
- d677ab6
<d677ab6>
move FileFormat from EGF to ExternalFile
File Changes
(1 file
<https://github.com/votinginfoproject/vip-specification/pull/491/files>)
- *M* vip_spec.xsd
<https://github.com/votinginfoproject/vip-specification/pull/491/files#diff-4c37f26c3d57d1d566a1758ae1e9f2b917ceb4b1c6bb9efa2eb45ac131802dfa>
(2)
Patch Links:
- https://github.com/votinginfoproject/vip-specification/pull/491.patch
- https://github.com/votinginfoproject/vip-specification/pull/491.diff
—
Reply to this email directly, view it on GitHub
<#491>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANFW7FZKWAPABTORHWIRBD3DBDRHAVCNFSM6AAAAAB7C5CY3OVHI2DSMVQWIX3LMV43ASLTON2WKOZTGEZTOMRXGUYDQMY>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has always confused me. A single ExternalFile can't have multiple file formats, right?