Skip to content

fix(no-export-in-script-setup): better report location #2701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 5, 2025
Merged

fix(no-export-in-script-setup): better report location #2701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
828999a
perf(no-export-in-script-setup): support autofix for vue/no-export-in…
chouchouji Feb 21, 2025
d5a96be
test(no-export-in-script-setup): update test cases
chouchouji Mar 5, 2025
b765d02
fix(no-export-in-script-setup): update fixable
chouchouji Mar 5, 2025
b92dc0a
refactor: optimize code
chouchouji Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions lib/rules/no-export-in-script-setup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,11 @@ module.exports = {
},
/** @param {RuleContext} context */
create(context) {
/** @param {ExportAllDeclaration | ExportDefaultDeclaration | ExportNamedDeclaration} node */
function verify(node) {
/**
* @param {ExportAllDeclaration | ExportDefaultDeclaration | ExportNamedDeclaration} node
* @param {SourceLocation} loc
*/
function verify(node, loc) {
const tsNode =
/** @type {TSESTreeExportAllDeclaration | TSESTreeExportDefaultDeclaration | TSESTreeExportNamedDeclaration} */ (
node
Expand All @@ -46,14 +49,24 @@ module.exports = {
}
context.report({
node,
loc,
messageId: 'forbidden'
})
}

return utils.defineScriptSetupVisitor(context, {
ExportAllDeclaration: verify,
ExportDefaultDeclaration: verify,
ExportNamedDeclaration: verify
ExportAllDeclaration: (node) => verify(node, node.loc),
ExportDefaultDeclaration: (node) => verify(node, node.loc),
ExportNamedDeclaration: (node) => {
// export let foo = 'foo', export class Foo {}, export function foo() {}
if (node.declaration) {
verify(node, context.getSourceCode().getFirstToken(node).loc)
}
// export { foo }, export { foo } from 'bar'
else {
verify(node, node.loc)
}
}
})
}
}
78 changes: 69 additions & 9 deletions tests/lib/rules/no-export-in-script-setup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,20 +92,62 @@ ruleTester.run('no-export-in-script-setup', rule, {
export * from 'foo'
export default {}
export class A {}
export const test = '123'
export function foo() {}
const a = 1
export { a }
export { fao } from 'bar'
</script>
`,
errors: [
{
message: '`<script setup>` cannot contain ES module exports.',
line: 3
line: 3,
endLine: 3,
column: 7,
endColumn: 26
},
{
message: '`<script setup>` cannot contain ES module exports.',
line: 4
line: 4,
endLine: 4,
column: 7,
endColumn: 24
},
{
message: '`<script setup>` cannot contain ES module exports.',
line: 5
line: 5,
endLine: 5,
column: 7,
endColumn: 13
},
{
message: '`<script setup>` cannot contain ES module exports.',
line: 6,
endLine: 6,
column: 7,
endColumn: 13
},
{
message: '`<script setup>` cannot contain ES module exports.',
line: 7,
endLine: 7,
column: 7,
endColumn: 13
},
{
message: '`<script setup>` cannot contain ES module exports.',
line: 9,
endLine: 9,
column: 7,
endColumn: 19
},
{
message: '`<script setup>` cannot contain ES module exports.',
line: 10,
endLine: 10,
column: 7,
endColumn: 32
}
]
},
Expand All @@ -124,15 +166,24 @@ ruleTester.run('no-export-in-script-setup', rule, {
errors: [
{
message: '`<script setup>` cannot contain ES module exports.',
line: 6
line: 6,
endLine: 6,
column: 7,
endColumn: 26
},
{
message: '`<script setup>` cannot contain ES module exports.',
line: 7
line: 7,
endLine: 7,
column: 7,
endColumn: 24
},
{
message: '`<script setup>` cannot contain ES module exports.',
line: 8
line: 8,
endLine: 8,
column: 7,
endColumn: 13
}
]
},
Expand All @@ -154,15 +205,24 @@ ruleTester.run('no-export-in-script-setup', rule, {
errors: [
{
message: '`<script setup>` cannot contain ES module exports.',
line: 3
line: 3,
endLine: 3,
column: 7,
endColumn: 13
},
{
message: '`<script setup>` cannot contain ES module exports.',
line: 4
line: 4,
endLine: 4,
column: 7,
endColumn: 13
},
{
message: '`<script setup>` cannot contain ES module exports.',
line: 5
line: 5,
endLine: 5,
column: 7,
endColumn: 16
}
]
}
Expand Down
Loading