Skip to content

fix(nuxt): mark compatibility for nuxt v4 stable #3009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025
Merged

fix(nuxt): mark compatibility for nuxt v4 stable #3009

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69f47e3
fix(nuxt): mark compatibility for nuxt v4 stable
GalacticHypernova Jul 17, 2025
1e5cf29
chore: simplify compatibility
GalacticHypernova Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/nuxt/src/module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const module: NuxtModule<ModuleOptions> = defineNuxtModule<ModuleOptions>({
name: 'pinia',
configKey: 'pinia',
compatibility: {
nuxt: '^3.15.0 || ^4.0.0-0',
nuxt: '^3.15.0 || ^4.0.0-0 || ^4.0.0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This might be a bug in the semver check instead: https://jubianchi.github.io/semver-check/#/^4.0.0-0/4.0.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we can simplify it further even
https://jubianchi.github.io/semver-check/#/^4.0.0/4.0.0-alpha

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! That didn't use to be the case with npm 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it is! But at least its a simpler syntax, so no harm in adopting it =)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really strange that it works because 4.0.0-alpha is clearly behind a 4.0.0 release and ^ means 'after' on the second and third digit.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

4.0.0-alpha isn't in this range.

Copy link
Contributor Author

@GalacticHypernova GalacticHypernova Jul 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Barbapapazes in that case, could it actually be a display error on semver's end? I guess we should support stable releases more than alpha pre-releases, but maybe in order to support both we would need to combine the previous compatibility string with this PR's?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current version with just the stable is fine

},
},
defaults: {},
Expand Down