-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(UST-1087): create nuxt
and next
packages
#6997
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fb15420
to
dc2c40c
Compare
dc2c40c
to
5263672
Compare
cb1dc8e
to
1bcfab3
Compare
@vue-storefront/nuxt
package for Vue Storefront 2@vue-storefront/nuxt
and @vue-storefront/next
packages
@vue-storefront/nuxt
and @vue-storefront/next
packagesnuxt
and next
packages
d29f2e8
to
7f53c4c
Compare
7f53c4c
to
181e919
Compare
ca4eeb6
to
580d243
Compare
28817f4
to
fcf8579
Compare
fcf8579
to
78b55c8
Compare
de9b645
to
7c95239
Compare
7c95239
to
c55bd74
Compare
β¦/vue-storefront into feat/UST-1087-nuxt-package
jagoral
commented
Dec 21, 2023
jagoral
commented
Dec 21, 2023
β¦/vue-storefront into feat/UST-1087-nuxt-package
filrak
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
@vue-storefront/nuxt
package for Vue Storefront 2@vue-storefront/nextjs
package (support for Pages and App Router)nuxt
package requires Node.js v18, therefore as a workaround:packages/storefront/packages
dirpackages/storefront
has been excluded from the Yarn workspacespackages/storefront
creates a nested workspacecontinuous-delivery-storefront.yml
workflow has been created (runs tests on Node18)@vue-storefront/next/client
entry is exported, where a"use client"
directive is used, so the code can be used in App RouterHow to test it locally?
cd packages/storefront
yarn
Then for Next
cd packages/next
yarn build
yarn dev:middleware
in one terminalyarn dev:pages-router
oryarn dev:app-router
in second terminalor Nuxt
cd packages/nuxt
yarn build
yarn dev:middleware
in one terminalyarn dev:pages-router
oryarn dev
in second terminalπ Checklist