refactor(useKeydown): optimize keydown event handling #8
+702
−170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
userquin
reviewed
Jul 2, 2025
johnleider
reviewed
Jul 11, 2025
johnleider
requested changes
Aug 12, 2025
Member
johnleider
left a comment
johnleider
left a comment
There was a problem hiding this comment.
I may be reading this wrong, but I really thing you might benefit from using useRegistry instead of managing handlerMap.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
commit: |
J-Sek
requested changes
Sep 2, 2025
AndreyYolkin
force-pushed
the
refactor/ae-keydown-with-registrar
branch
from
242bb48 to
24efe46
Compare
Member
|
Looks good but I don't quite understand exporting the handlerMap, what's the use case? |
…lated instances - Implement trinity pattern (createKeydown, createKeydownContext, createKeydownPlugin) - Move document listener inside each instance for proper isolation - Remove module-level global state (globalListener, handlerRegistry) - Update useKeydown() to consume context instead of accepting handlers directly - Refactor tests to work with new isolated architecture - Update documentation to reflect plugin-first approach and instance isolation Breaking changes: - useKeydown() now returns context instance instead of accepting handlers - Use createKeydown() for standalone instances - Use createKeydownPlugin() for app-level installation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use registrar and single event listener to listen to keydown in a more performant way