T7282: op-mode: show firewall group filtering and tab completion update

[markh0338]

Change summary

When showing firewall group , any dynamic groups are also shown along with the requested group name. Dynamic-groups, mac-groups and domain-groups are also not shown in tab completion.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

T7282

Related PR(s)

How to test / Smoketest result

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the components SMOKETESTS if applicable
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly

[github-actions]

👍
No issues in PR Title / Commit Title

[markh0338]

Linting failed in the firewall.py file, but not in the section I modified. I can reformat the file if you’d like, but I wanted to keep the focus on the purpose of the PR instead of linting.

[c-po]

Thank you for the submission. Looks like you are mangling two changes into one commit which is - from a software development and life cycle point - not a good idea.

Can you please split this change into two individual commits?

• Update TAB completion helpers
• Fix the for loop by an early exit in the script showing the firewall rules?

[markh0338]

Thank you for the submission. Looks like you are mangling two changes into one commit which is - from a software development and life cycle point - not a good idea.

Can you please split this change into two individual commits?

• Update TAB completion helpers

• Fix the for loop by an early exit in the script showing the firewall rules?

Just to clarify, would you want these completely split with different tasks and PRs? Or just different commits inside this PR?

[c-po]

Please use individual commits inside a single PR referencing the same task id.

[c-po]

Implementation looks good to me

[markh0338]

Rebased on current to sync up other firewall.py changes for remote-groups

[sever-sever]

Completion help is useful for firewall groups

[markh0338]

before this gets merged - I think there is an issue with how the path tab completion works. Admittedly, I don't know how all of that works either currently but there is an issue if a group type isn't found it doesn't continue down the list. so in this commit, if a dynamic group isn't found, the rest won't process.

[markh0338]

Completely overhauled the path completion logic. Previously, when using multiple entries in the completion help, a series of ls commands were chained together to list the directories. However, since these were executed in order, if the first directory had no groups defined, the remaining ls commands would not run—resulting in an incomplete group listing.

With the updated approach, each group directory is checked individually and only listed if it exists, ensuring more accurate and complete output.

[github-actions]

CI integration ❌ failed!

Details

CI logs

• CLI Smoketests (no interfaces) 👍 passed
• CLI Smoketests (interfaces only) ❌ failed
• Config tests 👍 passed
• RAID1 tests 👍 passed
• TPM tests 👍 passed