-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T7254: op-mode: Add spanning-tree op-mode commands #4422
base: current
Are you sure you want to change the base?
Conversation
Created stp.py to create output for spanning-tree info Modified show-bridge.xml.in to add: show bridge spanning-tree show bridge spanning-tree detail show bridge <interface> spanning-tree show bridge <interface> spanning-tree detail
Added stp.py to create output for spanning-tree info Modified op-mode-definitions\show-bridge.xml.in to add these commands: show bridge spanning-tree show bridge spanning-tree detail show bridge <interface> spanning-tree show bridge <interface> spanning-tree detail
❌ |
Could you please extend the PR message with an output of the RAW JSON data, too? |
Sure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition!
I would like to request also inly querying an individual bridge: show bridge spanning-tree br0 [detail]
with an optional detail argument, too.
Updated language of amRoot to " (This bridge is the root)" Co-authored-by: Christian Breunig <[email protected]>
Updated language of "VLANs are enabled/disabled" to "VLANs enabled/disabled" Co-authored-by: Christian Breunig <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and works as expected. It‘s a very nice addition. LGTM
Commits should be squashed and merged as suggestions got committed.
Modified op-mode-standardized.json
Sorry, I had to commit an update. I realized I didn't update |
CI integration 👍 passed! Details
|
Change summary
This PR will add missing commands for spanning-tree. The following commands are added:
Example config:
Output Examples:
Types of changes
Related Task(s)
https://vyos.dev/T7254
Related PR(s)
How to test / Smoketest result
Checklist: