Skip to content

T7292: add Python module client library for vyconfd #4427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 8, 2025

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Mar 31, 2025

Change summary

Add client request module for vyconfd.
This is needed for replacing the legacy my_cli_bin mediated components of configsession.py, among other uses.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this Mar 31, 2025
Copy link

github-actions bot commented Mar 31, 2025

👍
No issues in PR Title / Commit Title

@jestabro
Copy link
Contributor Author

Rebase over current.

@jestabro jestabro force-pushed the commit-post branch 2 times, most recently from 59f3bed to 97476d7 Compare March 31, 2025 18:59
@jestabro jestabro marked this pull request as ready for review April 4, 2025 18:24
@jestabro jestabro marked this pull request as draft April 4, 2025 18:27
@jestabro jestabro marked this pull request as ready for review April 4, 2025 19:30
Copy link

github-actions bot commented Apr 4, 2025

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@sever-sever sever-sever requested a review from Copilot April 7, 2025 10:20
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • libvyosconfig: Language not supported

Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty straightforward wrapping, I see no issues in it.

@dmbaturin dmbaturin merged commit 6522dcd into vyos:current Apr 8, 2025
16 of 17 checks passed
@vyosbot vyosbot added the mirror-initiated This PR initiated for mirror sync workflow label Apr 8, 2025
@vyosbot vyosbot added mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants