T7157: bgp: Added verification of the route-map existence in vrf import#4503
Merged
dmbaturin merged 1 commit intovyos:currentfrom May 13, 2025
Merged
T7157: bgp: Added verification of the route-map existence in vrf import#4503dmbaturin merged 1 commit intovyos:currentfrom
dmbaturin merged 1 commit intovyos:currentfrom
Conversation
|
👍 |
Added verification of the route-map existence in the vrf route-leaking.
c69d06b to
e35315a
Compare
c-po
approved these changes
May 12, 2025
Member
c-po
left a comment
There was a problem hiding this comment.
Added missing check for route-map existence.
Member
|
@aapostoliuk do we need backports for circinus/sagitta? If se please add the labels |
|
CI integration 👍 passed! Details
|
dmbaturin
approved these changes
May 13, 2025
Member
dmbaturin
left a comment
There was a problem hiding this comment.
We should certainly verify that the user isn't trying to assign a non-existent route-map, for VRF route leaking or anywhere. The original option was backported to Sagitta so this will also need backports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
Added verification of the route-map existence in the vrf route-leaking.
Types of changes
Related Task(s)
Related PR(s)
How to test / Smoketest result
Smoketests:
Checklist: