VPP: T7175: Added sflow plugin to build #962
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Sflow plugin to VPP build.
|
❌ |
This was referenced May 12, 2025
ServerForge
changed the title
sever-sever
requested changes
May 13, 2025
| @@ -15,6 +15,8 @@ apply_patches = false | |||
| pre_build_hook = """ | |||
| mkdir -p ../patches/vpp/ | |||
| rsync -av ../vyos-vpp-patches/patches/vpp/ ../patches/vpp/ | |||
| git clone https://github.com/sflow/vpp-sflow ../vpp-sflow | |||
There was a problem hiding this comment.
Can we use an additional package instead of cloning? After the vyos-vpp-patches
[[packages]]
name = "vpp-sflow"
commit_id = "v0.9.02-2" # tag or commit id
scm_url = "https://github.com/sflow/vpp-sflow"
build_cmd = "/bin/true"
apply_patches = false
This way we can get a specific commit id/tag and rebuild it properly if commit_id is changed.
There was a problem hiding this comment.
Updated and ran build to verify it still works as intended.
Added Sflow plugin to VPP build.
sever-sever
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
Added the VPP-Sflow plugin to the build.
Types of changes
Related Task(s)
https://vyos.dev/T7175
Related PR(s)
vyos/vyos-vpp#32
vyos/vyos-1x#4504
Checklist: