Skip to content

T7352: add arg to test script for running smoketests under vyconfd/commitd #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2025
Merged

T7352: add arg to test script for running smoketests under vyconfd/commitd #963

merged 2 commits into from
May 22, 2025

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented May 12, 2025 •
edited
Loading

Change summary

NOTE: this requires PR vyos/vyos-1x#4505 and related.

Add arg to scripts/check-qemu-install for testing under vyconf.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

vyos/vyconf#21
vyos/libvyosconfig#36
vyos/vyos-1x#4505

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this May 12, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 12, 2025 •
edited
Loading

👍
No issues in PR Title / Commit Title

@jestabro jestabro mentioned this pull request May 12, 2025
Merged
12 tasks
@github-actions github-actions bot added the current VyOS rolling release label May 12, 2025
This was referenced May 13, 2025
Merged
Merged
dmbaturin
dmbaturin approved these changes May 19, 2025
View reviewed changes
Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic is straightforward and will be necessary when vyconf is in. No objections.

@jestabro jestabro merged commit bc77b38 into vyos:current May 22, 2025
7 checks passed
@github-actions github-actions bot added the mirror-initiated This PR initiated for mirror sync workflow label May 22, 2025
@vyosbot vyosbot added mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbaturin dmbaturin dmbaturin approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev

@sever-sever sever-sever Awaiting requested review from sever-sever

@c-po c-po Awaiting requested review from c-po

Assignees

@jestabro jestabro

Labels
current VyOS rolling release mirror-completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jestabro @dmbaturin @vyosbot