feat[venom]: use memory ssa information for finer DFT effect dependencies #4670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4670 +/- ##
==========================================
- Coverage 92.92% 92.79% -0.13%
==========================================
Files 131 131
Lines 18991 19041 +50
Branches 3295 3310 +15
==========================================
+ Hits 17648 17670 +22
- Misses 905 931 +26
- Partials 438 440 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| StorageSSA, | ||
| TransientSSA, | ||
| ) | ||
| from vyper.venom.basicblock import IRBasicBlock, IRInstruction, IRVariable |
Check notice
Code scanning / CodeQL
Unused import Note
Comment on lines
+192
to
+193
| #if isinstance(mem_use.inst.operands[0], IRVariable): | ||
| # continue |
Check notice
Code scanning / CodeQL
Commented-out code Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture