Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-aam PR 230] Update aria-labelledby AXAPI mapping to use AXTitle #2199

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pkra
Copy link
Member

@pkra pkra commented May 22, 2024

@spectranaut
Copy link
Contributor

Include co-author when merging.

Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Rahim, this PRs has been moved, so please continue the work here :)

I have a few questions/comments for you:

  1. This looks good, but from the issue, it looks like aria-label is updated to AXTitle as well, where you doing that in a separate PR? Seems to me like it could be done here as well.
  2. Can you confirm whether there will need to be a change in firefox and chrome? Seems like it! if so we need to track those implementations.

@pkra pkra changed the base branch from monorepo_history--core-aam to main June 12, 2024 19:37
@pkra pkra changed the title [Monorepo] [core-aam PR 230] Update aria-labelledby AXAPI mapping to use AXTitle [core-aam PR 230] Update aria-labelledby AXAPI mapping to use AXTitle Jun 12, 2024
Copy link

netlify bot commented Aug 11, 2024

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 1426ffa
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/66b933ce9220c600083f66dc
😎 Deploy Preview https://deploy-preview-2199--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rahimabdi
Copy link
Contributor

Hello @spectranaut!

  1. This looks good, but from the issue, it looks like aria-label is updated to AXTitle as well, where you doing that in a separate PR? Seems to me like it could be done here as well.

Agreed (thank you), I've updated the PR to include both aria-label/aria-labelledby.

  1. Can you confirm whether there will need to be a change in firefox and chrome? Seems like it! if so we need to track those implementations.

No change is required for implementations, so related API tests should be crafted to allow either attribute. Although AXTitle is now the recommended AXAPI mapping for aria-label/aria-labelledby, engines may still use the legacy AXDescription attribute. James and I do not believe the older alternative needs to be documented by an evergreen spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update AXAPI mapping for aria-label, aria-labelledby to use AXTitle
3 participants