[css-forms-1] Add field-sizing to base select styles #11879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base select is always sized based on its content size rather than using the legacy fixed styling, so we set field-sizing to content !important.
lukewarlow
commented
Mar 9, 2025
| @@ -695,6 +695,11 @@ input[type=radio]::checkmark { | |||
| ## Selects & buttons | |||
|
|
|||
| ```css | |||
| select { | |||
| /* Base appearance select always sizes based on its contents. */ | |||
| field-sizing: content !important; | |||
There was a problem hiding this comment.
!important for now but if we decided to enable the legacy layout (size based on layout of longest option) we could remove that modifier and allow authors to set to fixed to enable it.
5 tasks
lukewarlow
commented
Mar 9, 2025
| @@ -695,6 +695,11 @@ input[type=radio]::checkmark { | |||
| ## Selects & buttons | |||
|
|
|||
| ```css | |||
| select { | |||
| /* Base appearance select always sizes based on its contents. */ | |||
| field-sizing: content !important; | |||
There was a problem hiding this comment.
We maybe only want this for dropdown select and not for listbox select but we can handle that once we have a selector to choose between them.
nt1m
approved these changes
Mar 9, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base select is always sized based on its content size rather than using the legacy fixed styling, so we set field-sizing to content !important.
See #11838 (comment)