[web-animations-2] s/animation-trigger-type/animation-trigger-behavior/

[szager-chromium]

Behavior is a more accurate and intuitive term than type.

Also rewrites the explanations of state, did trigger, and behavior for clarity.

Also fixes some bikeshed linking syntax to point to IDL attributes where appropriate.

[szager-chromium]

@flackr PTAL

[szager-chromium]

@ydaniv PTAL

[szager-chromium]

Preview of the changes:

https://foremost-electric-knuckle.glitch.me/

[ydaniv]

1 note before diving in, animation-trigger-type is also a CSS property, so if we change that name it should also be reflected in css-animations-2.

[flackr]

When trying to build this locally bikeshed seems to have issues with the &bs'; escape sequence:

LINE 2397:45: Character reference '&bs' didn't end in ;.
LINE 2398:25: Character reference '&bs' didn't end in ;.
LINE 2404:26: Character reference '&bs' didn't end in ;.
LINE 2528:57: Character reference '&bs' didn't end in ;.
LINE 2530:33: Character reference '&bs' didn't end in ;.
LINE 3724:36: Character reference '&bs' didn't end in ;.

However it also shouldn't be necessary to escape apostrophes, should it? When removing I can build and it seems to still have all of the correct linkage. It also seems like there are plenty of unescaped apostrophes in other specs: https://github.com/search?q=repo%3Aw3c%2Fcsswg-drafts+%2F%5Ba-z%5C%5D%5D%27s%2F&type=code

[flackr]

Am I correct that the substantive change here is the rename to behavior? It looked to me that the other changes were phrasing / syntactic without behavioral changes right?

+1 to @ydaniv's comment that this should update https://drafts.csswg.org/css-animations-2/#animation-trigger-type as well

[szager-chromium]

Am I correct that the substantive change here is the rename to behavior? It looked to me that the other changes were phrasing / syntactic without behavioral changes right?

+1 to @ydaniv's comment that this should update https://drafts.csswg.org/css-animations-2/#animation-trigger-type as well

Yes, the substantive change is the rename. I did reorder two of the sections and updated some of the language in ways that I believe add clarity, but the substance is the same.

[szager-chromium]

When trying to build this locally bikeshed seems to have issues with the &bs'; escape sequence:

LINE 2397:45: Character reference '&bs' didn't end in ;.
LINE 2398:25: Character reference '&bs' didn't end in ;.
LINE 2404:26: Character reference '&bs' didn't end in ;.
LINE 2528:57: Character reference '&bs' didn't end in ;.
LINE 2530:33: Character reference '&bs' didn't end in ;.
LINE 3724:36: Character reference '&bs' didn't end in ;.

However it also shouldn't be necessary to escape apostrophes, should it? When removing I can build and it seems to still have all of the correct linkage. It also seems like there are plenty of unescaped apostrophes in other specs: https://github.com/search?q=repo%3Aw3c%2Fcsswg-drafts+%2F%5Ba-z%5C%5D%5D%27s%2F&type=code

I was getting bikeshed errors without the quoting. Let me see if I can work around it.

[szager-chromium]

1 note before diving in, animation-trigger-type is also a CSS property, so if we change that name it should also be reflected in css-animations-2.

Done.

[szager-chromium]

When trying to build this locally bikeshed seems to have issues with the &bs'; escape sequence:

LINE 2397:45: Character reference '&bs' didn't end in ;.
LINE 2398:25: Character reference '&bs' didn't end in ;.
LINE 2404:26: Character reference '&bs' didn't end in ;.
LINE 2528:57: Character reference '&bs' didn't end in ;.
LINE 2530:33: Character reference '&bs' didn't end in ;.
LINE 3724:36: Character reference '&bs' didn't end in ;.

However it also shouldn't be necessary to escape apostrophes, should it? When removing I can build and it seems to still have all of the correct linkage. It also seems like there are plenty of unescaped apostrophes in other specs: https://github.com/search?q=repo%3Aw3c%2Fcsswg-drafts+%2F%5Ba-z%5C%5D%5D%27s%2F&type=code

I was getting bikeshed errors without the quoting. Let me see if I can work around it.

Hmm, the errors are gone for me now so I removed the &bs; syntax.