Clarifies the relationship between the systemAudio option and monitor display surfaces.#327
Merged
Merged
Conversation
1 task
eladalon1983
approved these changes
Jun 19, 2025
| <p>Describes whether an application invoking | ||
| {{MediaDevices/getDisplayMedia()}} would like the user agent to include | ||
| system audio among the audio sources offered to the user.</p> | ||
| system audio among the audio sources offered to the user for |
Member
There was a problem hiding this comment.
Instead of "for", maybe we should say "in conjunction with." (Throughout.)
martinthomson
left a comment
martinthomson
left a comment
Member
There was a problem hiding this comment.
This would be clearer if it also said "this only applies to requests that include XXX display surfaces" for both of the audio constraints. It is currently a bit indirect.
youennf
approved these changes
Jul 10, 2025
jan-ivar
reviewed
Jul 17, 2025
jan-ivar
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies the relationship between the
systemAudiooption and monitor display surfaces.The description of the
SystemAudioPreferenceEnum's "include" enum already specifies thatsystemAudiois linked to monitor display surfaces. This update aims to further clarify this existing relationship within the specification.Preview | Diff