Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync WCAG-2.1 branch contents with its change log and errata #4179

Open
wants to merge 12 commits into
base: WCAG-2.1
Choose a base branch
from
Open

Sync WCAG-2.1 branch contents with its change log and errata #4179

wants to merge 12 commits into from
+170 −156

Conversation

kfranqueiro
Copy link
Contributor

@kfranqueiro kfranqueiro commented Dec 18, 2024 •
edited
Loading

Reminder: when the time comes to merge, we might want to consider a rebase merge for this rather than a squash merge, to retain the cherry-picking breadcrumb trail.

Background

The 2024-12-12 republication of WCAG 2.1 added a new set of entries to the change log; however, most of these changes were never backported to the WCAG-2.1 branch, and therefore did not make it into the republication. In addition, there were several other errata intended to be common between 2.1 and 2.2 which were neither backported nor referenced in the new change log.

Changes

This branch includes a few sets of changes as a starting point for review and discussion; here's a breakdown. It may be easier to review these on a commit-by-commit basis rather than attempting to view the full diff at once.

  • The first commit reverts a change (Replicating the 2.2 errata #3742) that was incorrectly backported from main (applied against pointer-input rather than single-pointer)
  • The subsequent commits up until "Sync ED with publication" backport changes that were referenced in the new change log entries but had not been applied to WCAG 2.1
  • The "Sync ED with production" commit ports corrections which were applied in TR space but didn't make it into the editor's draft on this branch
  • The commits thereafter backport additional changes that were raised as errata common between 2.2 and 2.1 but were not referenced in the 2024-12-12 change log update for 2.1
  • The final commit attempts to further update the change log in anticipation of another republish (I expect there may be heavy commentary on this point)
    • Note I fixed some indentation while I was at it; it will be easier to view ignoring whitespace (add ?w=1 to the commit's URL or choose "Hide whitespace" from the cog menu in the sidebar)

All backports were performed with git cherry-pick -x to include information on the originating commit.

Preview

Diff (between the December republication of 2.1 and this branch as of 2025-01-30)

@kfranqueiro kfranqueiro requested review from alastc and iadawn December 18, 2024 22:48
@kfranqueiro kfranqueiro force-pushed the kgf-WCAG-2.1-changelog-sync branch from 9e192a8 to 81a1f60 Compare December 19, 2024 15:43
@kfranqueiro kfranqueiro mentioned this pull request Dec 19, 2024
Draft
@kfranqueiro kfranqueiro force-pushed the kgf-WCAG-2.1-changelog-sync branch from 81a1f60 to 294b24d Compare December 19, 2024 17:40
@iadawn iadawn requested review from mbgower and bruce-usab January 29, 2025 16:28
@mbgower
Copy link
Contributor

mbgower commented Jan 29, 2025

Thanks for including updates to the Change Log section, @kfranqueiro
I assume changes to the actual errata page will be covered in a separate PR (since it's in WAI, not TR space)

kfranqueiro and others added 12 commits January 30, 2025 10:20
@kfranqueiro
Revert "Replicating the 2.2 errata (#3742)"
749c872 
This reverts commit b24abad.

This was not properly replicated - it updated the wrong file
@patrickhlauke @kfranqueiro
Change <ol> to <ul> when no order is intended (normative) (#3756)
87831aa 
Sibling PR to #3518

<!--
    This comment and the below content is programmatically generated.
    You may add a comma-separated list of anchors you'd like a
    direct link to below (e.g. #idl-serializers, #idl-sequence):

    Don't remove this comment or modify anything below this line.
    If you don't want a preview generated for this pull request,
    just replace the whole of this comment's content by "no preview"
    and remove what's below.
-->
***
<a href="https://pr-preview.s3.amazonaws.com/w3c/wcag/pull/3756.html"
title="Last updated on Mar 23, 2024, 4:00 PM UTC (cff6720)">Preview</a>
| <a
href="https://pr-preview.s3.amazonaws.com/w3c/wcag/3756/bf44269...cff6720.html"
title="Last updated on Mar 23, 2024, 4:00 PM UTC (cff6720)">Diff</a>

(cherry picked from commit 67f8420)
@patrickhlauke @kfranqueiro
Change "tablets...mobile devices" to a better structure without sugge…
0657809 
…sting tablets AREN'T mobile devices (#3776)

This removes the weird ambiguity of "why list tablets separately from
mobile devices" and closes #3750

Co-authored-by: Mike Gower <[email protected]>
(cherry picked from commit 378d4bf)
@mbgower @kfranqueiro
Cfc style updates (#4080)
c1c8c8c 
Style changes to normative documents made to ensure consistency as part
of the republishing of WCAG 2.2
- Ensures all normative occurrences of "web page" are two words and
lower case.
- Ensures all normative occurrences of "website" are a single word, not
capitalized.
- Ensures all normative occurrences of "success criterion/criteria" that
do not specify SCs by name, are lower case
- Ensures all normative occurrences of "web content" and other uses of
"web" are lower case

<!--
    This comment and the below content is programmatically generated.
    You may add a comma-separated list of anchors you'd like a
    direct link to below (e.g. #idl-serializers, #idl-sequence):

    Don't remove this comment or modify anything below this line.
    If you don't want a preview generated for this pull request,
    just replace the whole of this comment's content by "no preview"
    and remove what's below.
-->
***
<a href="https://pr-preview.s3.amazonaws.com/w3c/wcag/pull/4080.html"
title="Last updated on Oct 4, 2024, 3:14 PM UTC (571cf14)">Preview</a> |
<a
href="https://pr-preview.s3.amazonaws.com/w3c/wcag/4080/bf4b123...571cf14.html"
title="Last updated on Oct 4, 2024, 3:14 PM UTC (571cf14)">Diff</a>

---------

Co-authored-by: Alastair Campbell <[email protected]>
(cherry picked from commit a2c3cb3)
@maryjom @kfranqueiro
Editorial suggestions for consistent links to definitions and capital…
9f292ea 
…ization (#3038)

Co-authored-by: Francis Storr <[email protected]>
Co-authored-by: Kenneth G. Franqueiro <[email protected]>
Co-authored-by: Mike Gower <[email protected]>
(cherry picked from commit 1b2d567)
@kfranqueiro
Remove term reference from #3038 backport that doesn't exist in 2.1
10b6b76
@kfranqueiro
Sync ED with publication
46193b5 
- Fix year reference preceding latest change log list
- Capitalize change log list items
@patrickhlauke @kfranqueiro
Update definition for single pointer (#3536)
24b564c 
The definition for "single pointer" has had issues for a long time, as
it mixes the idea of what a pointer *is* with the action(s) *performed*
using a pointer.

I originally tried to fix this, but there was no appetite for it once
2.1 was released. However, with 2.2 and the new 2.5.7 Dragging Movement
SC, the broken definition is causing actual misunderstandings/illogical
non-sequiturs.

See #749 (comment) and
the recent #3535 where this is once
again causing a non-sequitur

Closes #3535

(this is effectively a follow-up to #809
which had disambiguated things, but the definition had since been
changed further/again to reintroduce the ambiguous wording we have at
this point which confuses input with action)

This would be applied to WCAG 2.1 and 2.2, unless there is a decision to
only apply it to 2.2.

EDIT: Also closes #394

<!--
    This comment and the below content is programmatically generated.
    You may add a comma-separated list of anchors you'd like a
    direct link to below (e.g. #idl-serializers, #idl-sequence):

    Don't remove this comment or modify anything below this line.
    If you don't want a preview generated for this pull request,
    just replace the whole of this comment's content by "no preview"
    and remove what's below.
-->
***
<a href="https://pr-preview.s3.amazonaws.com/w3c/wcag/pull/3536.html"
title="Last updated on Mar 8, 2024, 7:30 PM UTC (6c36df1)">Preview</a> |
<a
href="https://pr-preview.s3.amazonaws.com/w3c/wcag/3536/afbf9ee...6c36df1.html"
title="Last updated on Mar 8, 2024, 7:30 PM UTC (6c36df1)">Diff</a>

---------

Co-authored-by: Alastair Campbell <[email protected]>
(cherry picked from commit a9dbe11)
@patrickhlauke @kfranqueiro
Add "modality" to single pointer definition with examples of single p…
8f8c286 
…ointer interactions (#4070)

Follow-up to
#3536 (comment) to
potentially address concerns by @WilcoFiers @dbjorge

Tries to more clearly differentiate "input" as in the *modality* from
the gestures/interactions that are the *result* of using a particular
input *modality*

<!--
    This comment and the below content is programmatically generated.
    You may add a comma-separated list of anchors you'd like a
    direct link to below (e.g. #idl-serializers, #idl-sequence):

    Don't remove this comment or modify anything below this line.
    If you don't want a preview generated for this pull request,
    just replace the whole of this comment's content by "no preview"
    and remove what's below.
-->
***
<a href="https://pr-preview.s3.amazonaws.com/w3c/wcag/pull/4070.html"
title="Last updated on Sep 20, 2024, 8:10 PM UTC (a79bb49)">Preview</a>
| <a
href="https://pr-preview.s3.amazonaws.com/w3c/wcag/4070/4213bf6...a79bb49.html"
title="Last updated on Sep 20, 2024, 8:10 PM UTC (a79bb49)">Diff</a>

---------

Co-authored-by: Alastair Campbell <[email protected]>
Co-authored-by: Mike Gower <[email protected]>
(cherry picked from commit b9cf8f8)
@mbgower @kfranqueiro
Update used-in-an-unusual-or-restricted-way.html (#3707)
39f1cc5 
closes #3487 by making the reference WCAG 2 and not WCAG 2.1.
Similar to effort in #3585
It is unclear to me if the change needs to be made in the hmtl or in one
of these source files, where the definition also occurs, so citing them
as part of the change /wcag20/sources/wcag2-src.xml
/wcag20/sources/wcag2-src.REC.xml

Note that this change is based on existing non-normative information
under [Background on WCAG
2](https://www.w3.org/TR/WCAG22/#background-on-wcag-2) in the existing
TR, which reads in part:
>Where this document refers to WCAG 2 it is intended to mean any and all
versions of WCAG that start with 2.

(cherry picked from commit eabc5e3)
@scottaohara @kfranqueiro
Update mention of "list" to "list item" in programmatically-determine… (
00ae225 
#3362)

closes #3361

updates the term example to mention "list item" instead of "list" to be
more accurate to what the intent of that likely was trying to convey.

Additionally, links to the HTML term of 'paragraph', which I would
submit could resolve issues such as #2109

<!--
    This comment and the below content is programmatically generated.
    You may add a comma-separated list of anchors you'd like a
    direct link to below (e.g. #idl-serializers, #idl-sequence):

    Don't remove this comment or modify anything below this line.
    If you don't want a preview generated for this pull request,
    just replace the whole of this comment's content by "no preview"
    and remove what's below.
-->
***
<a href="https://pr-preview.s3.amazonaws.com/w3c/wcag/pull/3362.html"
title="Last updated on Aug 25, 2023, 7:14 PM UTC (44450fb)">Preview</a>
| <a
href="https://pr-preview.s3.amazonaws.com/w3c/wcag/3362/6b2b211...44450fb.html"
title="Last updated on Aug 25, 2023, 7:14 PM UTC (44450fb)">Diff</a>

(cherry picked from commit 3d88e14)
@kfranqueiro
Update change log to reflect fixes since 2024-12-12
eda56be
@kfranqueiro kfranqueiro force-pushed the kgf-WCAG-2.1-changelog-sync branch from 294b24d to eda56be Compare January 30, 2025 15:32
@netlify Netlify
Copy link

netlify bot commented Jan 30, 2025 •
edited
Loading

✅ Deploy Preview for wcag21 ready!

Name Link
🔨 Latest commit eda56be
🔍 Latest deploy log https://app.netlify.com/sites/wcag21/deploys/679b9b9496272e00080880a3
😎 Deploy Preview https://deploy-preview-4179--wcag21.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bruce-usab
bruce-usab reviewed Feb 21, 2025
View reviewed changes
guidelines/terms/20/blocks-of-text.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I had to educate myself about data-*

Copy link
Contributor Author

@kfranqueiro kfranqueiro Feb 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This data attribute is respec-specific: https://respec.org/docs/#data-lt

bruce-usab
bruce-usab approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@bruce-usab bruce-usab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ken!

@bruce-usab
Copy link
Contributor

Reviewed on backlog call 2/21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruce-usab bruce-usab bruce-usab approved these changes

@mbgower mbgower mbgower approved these changes

@alastc alastc Awaiting requested review from alastc

@iadawn iadawn Awaiting requested review from iadawn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kfranqueiro @mbgower @bruce-usab @patrickhlauke @maryjom @scottaohara