Add a way to find navigable's container #811
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/container-locator
branch
2 times, most recently
from
217da7c
to
b6e0478
Compare
OrKoN
force-pushed
the
orkon/container-locator
branch
from
b6e0478
to
0a2b364
Compare
OrKoN
added
needs-discussion
whimboo
reviewed
Nov 11, 2024
| @@ -2960,6 +2960,7 @@ To <dfn>await a navigation</dfn> given |navigable|, |request|, |wait condition|, | |||
| browsingContext.Locator = ( | |||
| browsingContext.AccessibilityLocator / | |||
| browsingContext.CssLocator / | |||
| browsingContext.ContainerLocator / | |||
There was a problem hiding this comment.
Is there a reason why we cannot have the container as part of the return value of the browsingContext.getTree command? It would be somewhat similar to the clientWindow field.
There was a problem hiding this comment.
Yes, that API currently does not include any shared references from script and would not allow expressing the ownership of the returned DOM element.
There was a problem hiding this comment.
To clarify: we could probably plumb it via the getTree along with the other options we might need to define how to return the element but to me it looks like locateNodes is a better place compared to the getTree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifies one of the possible ways to implement this: using a locator.
Closes #794
Preview | Diff