-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10th tutorial video review #120
base: main
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for whatiswot failed.
|
I am not sure about the pronunciation of DECT ULE and Wi-SUN (See 2:00). I think ULE should at least be spelled. @egekorkan Do you know how they are usually pronounced? |
I would say we simply remove those two examples. They are a bit corner case and it would be difficult to back them up with TDs later on. |
Tutorials/whatiswot/10-Application_Domains/10-Application-Domains.vtt
Outdated
Show resolved
Hide resolved
standardized approach for connecting and integrating smart devices, services, and applications into the Web. | ||
|
||
00:00:45.375 --> 00:00:56.725 | ||
Now, let us introduce some of the WoT application domains: Smart Homes, Industrial Applications, Agriculture, and Smart Cities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the smart home wiggles but the others don't? Also, there should be a bit more pause after smart cities before moving to next slide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smart home was wiggling to show it was being presented next. should i make them all wiggle instead or none of them should wiggle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wiggling should happen just before the transition in second 59.
Tutorials/whatiswot/10-Application_Domains/10-Application-Domains.vtt
Outdated
Show resolved
Hide resolved
Tutorials/whatiswot/10-Application_Domains/10-Application-Domains.vtt
Outdated
Show resolved
Hide resolved
Tutorials/whatiswot/10-Application_Domains/10-Application-Domains.vtt
Outdated
Show resolved
Hide resolved
Tutorials/whatiswot/10-Application_Domains/10-Application-Domains.vtt
Outdated
Show resolved
Hide resolved
All of the requested changes have been made except the "wiggling" issue. I will proceed with the further feedback on that. Video can be reviewed from the same link. |
The important feedback is addressed. One pronunciation and animation fix is still needed. Afterwards, I will ask feedback from @relu91 . |
I delayed the wiggle until 00:54 and revised the pronunciation of PCs (however I am not sure of if it is okay). Please review the updated link. |
The wiggle should be a bit later but the animation is too fast (or talking is too slow). The sentence should finish before wiggling and then the transition to the inside of the home starts. |
I added more delay to the wiggle and updated the video. |
All my concerns are addressed, we will wait for @relu91 review before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A generic comment about use cases. I video explains correctly the different use cases but it fails to convey what WoT can do for the different domains. It is like we are explaining well- known IoT use cases. We are listing different protocols in the description why don't explicitly say that this diversity make difficult to create one-fit-all solutions?
It is a set of standards defined by the World Wide Web Consortium (W3C) for the interoperability of different Internet of Things platforms and application domains. | ||
|
||
The WoT aims to preserve and complement existing IoT standards and solutions by providing a standardized approach for connecting and integrating smart devices, services, and applications into the Web. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The animations here feel out of sync with the text. The sentence starts by mentioning the W3C but the animation shows a document structure and only after a few seconds shows the consortium animation. It is like the video can't keep up with what is narrated. Maybe We should choose one of the two animations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do such that we move the W3C mention to the end of the sentence. If it is still too fast, we can remove the W3C slide/animation.
So this was inspired from the architecture document since it also starts in this generic fashion. So I propose to do the following changes:
|
Please use the following for reviews: https://murf.ai/share/loroxo5j