Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10th tutorial video review #120

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

handealptekin
Copy link
Contributor

@handealptekin handealptekin commented Nov 9, 2023

Please use the following for reviews: https://murf.ai/share/loroxo5j

Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for whatiswot failed.

Name Link
🔨 Latest commit fc9a0e0
🔍 Latest deploy log https://app.netlify.com/sites/whatiswot/deploys/655d14cf0eafcb0008e01188

@FadySalama
Copy link

FadySalama commented Nov 10, 2023

I am not sure about the pronunciation of DECT ULE and Wi-SUN (See 2:00). I think ULE should at least be spelled. @egekorkan Do you know how they are usually pronounced?

@egekorkan
Copy link
Collaborator

I would say we simply remove those two examples. They are a bit corner case and it would be difficult to back them up with TDs later on.

standardized approach for connecting and integrating smart devices, services, and applications into the Web.

00:00:45.375 --> 00:00:56.725
Now, let us introduce some of the WoT application domains: Smart Homes, Industrial Applications, Agriculture, and Smart Cities.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the smart home wiggles but the others don't? Also, there should be a bit more pause after smart cities before moving to next slide

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smart home was wiggling to show it was being presented next. should i make them all wiggle instead or none of them should wiggle?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wiggling should happen just before the transition in second 59.

@handealptekin
Copy link
Contributor Author

All of the requested changes have been made except the "wiggling" issue. I will proceed with the further feedback on that. Video can be reviewed from the same link.
I also added the new outro to the end.

@egekorkan
Copy link
Collaborator

The important feedback is addressed. One pronunciation and animation fix is still needed. Afterwards, I will ask feedback from @relu91 .

@handealptekin
Copy link
Contributor Author

I delayed the wiggle until 00:54 and revised the pronunciation of PCs (however I am not sure of if it is okay). Please review the updated link.

@egekorkan
Copy link
Collaborator

The wiggle should be a bit later but the animation is too fast (or talking is too slow). The sentence should finish before wiggling and then the transition to the inside of the home starts.

@egekorkan egekorkan added the tutorial topics on our tutorials such as what is wot or quickstart label Dec 1, 2023
@handealptekin
Copy link
Contributor Author

I added more delay to the wiggle and updated the video.

@egekorkan
Copy link
Collaborator

All my concerns are addressed, we will wait for @relu91 review before merging.

@egekorkan egekorkan requested a review from relu91 December 8, 2023 09:39
Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A generic comment about use cases. I video explains correctly the different use cases but it fails to convey what WoT can do for the different domains. It is like we are explaining well- known IoT use cases. We are listing different protocols in the description why don't explicitly say that this diversity make difficult to create one-fit-all solutions?

Comment on lines +5 to +7
It is a set of standards defined by the World Wide Web Consortium (W3C) for the interoperability of different Internet of Things platforms and application domains.

The WoT aims to preserve and complement existing IoT standards and solutions by providing a standardized approach for connecting and integrating smart devices, services, and applications into the Web.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The animations here feel out of sync with the text. The sentence starts by mentioning the W3C but the animation shows a document structure and only after a few seconds shows the consortium animation. It is like the video can't keep up with what is narrated. Maybe We should choose one of the two animations?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do such that we move the W3C mention to the end of the sentence. If it is still too fast, we can remove the W3C slide/animation.

@egekorkan
Copy link
Collaborator

A generic comment about use cases. I video explains correctly the different use cases but it fails to convey what WoT can do for the different domains. It is like we are explaining well- known IoT use cases. We are listing different protocols in the description why don't explicitly say that this diversity make difficult to create one-fit-all solutions?

So this was inspired from the architecture document since it also starts in this generic fashion. So I propose to do the following changes:

  • Before starting with the use cases, we mention that WoT works for "all" IoT use cases, such as...
  • At the end of each use case, we mention how WoT relates to this:
    • WoT supports the architectures we showed since it supports local, edge and cloud connectivity, while integrating various protocols.
    • (same as above but rephrase intelligently) but also clearly mentioning that we support industrial protocols (smart home is more generic).
    • Agriculture: Not sure what to add at the end
    • Smart City: WoT works will in smart cities since it helps avoiding vendor lock-in by relying on open standards to achieve interoperability in spite of a big number of subsystems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tutorial topics on our tutorials such as what is wot or quickstart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants