Fix: Increase logo visibility in contrast themes / high-contrast mode #463#516
Open
GajulaSamatha wants to merge 1 commit intowagtail:mainfrom
Open
Fix: Increase logo visibility in contrast themes / high-contrast mode #463#516GajulaSamatha wants to merge 1 commit intowagtail:mainfrom
GajulaSamatha wants to merge 1 commit intowagtail:mainfrom
Conversation
…-contrast mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first PR, so if I made any mistakes, please excuse me and kindly guide me in the right direction. I hope to learn something new through this!
The issue is #463
To solve this issue, I followed @thibaudcolas sir's suggestion of adding" forced-color-adjust: none". It successfully worked when switching to system's high-contrast mode from website's dark mode.
However, while testing in light mode, there was no specific background color applied to the logo, which made it easy for contrast themes to override it. So, I explicitly added background-color: white here (these styles are applied in light mode):
these are the styles applying in the light mode of the website.
During testing, I also observed that PNG format logos are better in such cases, since their background color can be styled easily. For other formats, the appearance may not be ideal. You can see the difference here:
The first logo is a PNG.
The second one is not, and does not blend well.
I tested this in Chrome, Microsoft Edge and Fire Fox browsers.