Open
Conversation
Collaborator
|
This PR looks good. I have it up on staging currently. Unfortunately since we have basic auth set up on the site that blocks site previews and Heroku is being fussy right now, there is no good way to test whether the social previews look good. I may push this to production anyway since everything else seems to be fine on staging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #514
Updated social sharing image dimensions using
fill-1200x630to match recommended sizes across most of the platforms.Additional Note:
Some blog posts currently do not meet the required minimum description length of 100 characters. we could consider adding
min=100to the introduction field.Not sure about all other platforms, but linkedin recommends a minimum of 100 characters.