docs(review-pr): add false-positive rules from warp-server feedback#31
Draft
captainsafia wants to merge 1 commit into
Draft
docs(review-pr): add false-positive rules from warp-server feedback#31captainsafia wants to merge 1 commit into
captainsafia wants to merge 1 commit into
Conversation
Add two evidence-backed rules to the review-pr skill, derived from human replies to oz-for-oss review comments on warp-server PRs over the last week: - Verify language/runtime/database semantics before flagging code as broken; a confident CRITICAL/IMPORTANT comment with a wrong fix is worse than none. - Keep comments mutually consistent within a single review. Both are backed by warp-server PR #11910, where the bot asserted incorrect PostgreSQL chr(0)/NUL-byte semantics, proposed a fix that would guarantee a query failure, and contradicted its own earlier (correct) comment; the maintainer rebutted the same point across three threads. Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds two evidence-backed false-positive rules to the
review-prskill's Review Scope, derived from human feedback on agent-authored review comments.Why
Ran the warp-server
update-pr-reviewworkflow over the last 7 days ofoz-for-ossreview comments onwarpdotdev/warp-serverPRs (15 agent comments that received human replies; all on code PRs). Most comments were validated by maintainers, but one recurring failure mode stood out:chr(0)/ NUL bytes and proposed areplace(..., chr(0), '')fix that would have guaranteed a query failure (chr(0)itself raisesnull character not permitted). Worse, those suggestions contradicted the bot's own earlier, correct comment in the same review asking to removechr(0). The maintainer had to rebut the same point twice.Changes
Two new bullets in
.agents/skills/review-pr/SKILL.md:CRITICAL/IMPORTANTcomment with a wrong fix is worse than no comment. Lower severity and describe the risk when unsure rather than prescribing a concrete fix.Spec PRs in the window had no agent review comments (only human-to-human design discussion), so
review-specis intentionally left unchanged.cc @captainsafia
Conversation: https://staging.warp.dev/conversation/a5946d89-3ced-4943-ba85-f2ef0ccd30be
Run: https://oz.staging.warp.dev/runs/019ee065-8132-7316-8773-a4abce136cd1
This PR was generated with Oz.