Add Profile field support to HTTP ContentType (resolves #127) #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warriordog
approved these changes
May 14, 2024
There was a problem hiding this comment.
@puzzler995 thank you so much for the contribution! I left a few requests, but I can make the changes myself if you prefer.
| /// </summary> | ||
| /// <param name="MediaType">A MIME type for the header</param> | ||
| /// <param name="Profile">A profile to append to the MIME type, leave empty for none</param> | ||
| public record struct ContentType(string MediaType, string Profile); |
There was a problem hiding this comment.
can we make Profile optional, with a default value of ""?
| return obj; | ||
| } | ||
|
|
||
| private static bool IsContentTypeMatch(MediaTypeHeaderValue actual, ActivityPubOptions.ContentType expected) { |
There was a problem hiding this comment.
could we move this logic to the equality method in ContentType? https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/proposals/csharp-9.0/records#equality-members
| foreach (var mimeType in apOptions.RequestContentTypes) | ||
| { | ||
| var mediaType = new MediaTypeWithQualityHeaderValue(mimeType); | ||
| var mediaType = new MediaTypeWithQualityHeaderValue(mimeType.MediaType); |
There was a problem hiding this comment.
could we move this logic to an implicit cast in ContentType?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified ActivityPubOptions and ActivityPubClient to instead have a ContentType record struct, so it can handle both MediaType and Profile.
Feel free to let me know if there's anything I need to change. I've tested it as much as I can, but if you know of any softwares that actually follow the spec on this that I can test against, I will for sure.