-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Moving logic from templates to libs #2989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
infomiho
wants to merge
96
commits into
main
Choose a base branch
from
templates-to-libs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,962
−347
Open
Changes from all commits
Commits
Show all changes
96 commits
Select commit
Hold shift + click to select a range
b4e1769
WIP initial implementation
infomiho 8b708bb
Apply the SDK location hack to the libs
infomiho 49d979c
Include libs in the built CLI
infomiho a352e57
Merge branch 'main' into templates-to-libs
infomiho 97a6838
Add build config. Copy libs in the Dockerfile.
infomiho 121901f
Update todoApp package-lock.json
infomiho 4e248ae
Merge branch 'main' into templates-to-libs
infomiho ac9d038
Fixes libs deps install in Dockerfile
infomiho 3840e58
Move to using npm pack
infomiho db8aaeb
Formatting
infomiho ac55723
Client entry point experiment
infomiho 6dfc790
Fix copy command
infomiho 7a84ae8
Formatting
infomiho e8c955a
Refactor code
infomiho f0cfe95
Cleanup
infomiho 2f77c1c
Merge branch 'main' into templates-to-libs
infomiho 36b720c
Install script update
infomiho 083fecb
Append hash to tarball path
infomiho 9a70244
Exclude auth lib from Vite optimizations
infomiho b450ef2
Test auth client code, test using peerDependencies.
infomiho 00e6fbf
Migrate to tsdown
infomiho 90eab52
Refactor unit tests
infomiho 6b6b2f7
Move typeVersions comment
infomiho 3c818cd
d.ts sourcemap. cleanup.
infomiho 7e76f65
PR comments
infomiho 43aaac5
Refactor
infomiho 1073098
Update shell scripts
infomiho 828b096
Use newtype
infomiho aa05550
Fix unit tests
infomiho c4099d5
Update exports to be explict about sdk and server exports
infomiho 82f258c
Refactor WaspLib to have the checksum from creation
infomiho c3454d7
Copy libs to both out and build dir
infomiho 22958f5
Update the README
infomiho 9f3a53a
Update README and WaspLib to clarify library versioning and improve S…
infomiho a06e101
Remove redundant copying of libs to the build directory
infomiho 1e1d36c
Merge branch 'main' into templates-to-libs
infomiho 190e789
PR comments
infomiho fb548b0
Fix Dockerfile consistency
infomiho 48dfe49
Comment dots, scripts cleanup.
infomiho 58fe09a
Formatting
infomiho bd54fb4
Merge branch 'main' into templates-to-libs
infomiho ef0182b
Improve Tarball module
infomiho 8851649
WaspLibs comment
infomiho 9fc9e17
Add WaspLib comment
infomiho 8a4ce86
Define SDK package name
infomiho a88c972
Unit tests helper
infomiho 5bd2680
PR comments
infomiho 4f0a8e7
Naming
infomiho 211a04b
Update unit tests
infomiho 03066ee
Move getting WaspLibs out of AppSpec
infomiho ae1255b
Ignore `tgz` files in e2e tests (#3078)
infomiho b9ace98
Merge branch 'main' into templates-to-libs
infomiho f50e54b
Fix unit tests
infomiho 2478372
Merge branch 'main' into templates-to-libs
infomiho cd5347c
Remove typesVersions since it's redundant now
infomiho 438314a
Rename from @wasp.sh/{libs-auth => lib-auth}
infomiho 10803d4
Improve password tests
infomiho 52fe7f2
Add Reader monad to Generator to use WaspLibs more easily
infomiho f2df493
Replace explicit copying of libs with generating copy file drafts
infomiho b234395
PR comments
infomiho 669faca
Merge branch 'main' into templates-to-libs
infomiho 4e6ddbb
Merge branch 'main' into templates-to-libs
infomiho 5f3078e
PR comments
infomiho b0417a3
Named empty waspLibs list
infomiho a695db1
Update package copying scripts safety
infomiho cd6940b
Rename npm dep making fn
infomiho 5771e1f
Update libs README
infomiho 4b5a1c7
Simplify makeWaspLib
infomiho 133e837
Return CI note for the packages README
infomiho bcab437
Update tsconfig to be more general
infomiho f1a21e0
Use ESM only profile for arethetypeswrong
infomiho 563c00c
Fix formatting
infomiho 7c08e2d
Merge branch 'main' into templates-to-libs
infomiho e2d5eda
Update unit tests
infomiho 12b925a
Include `files` note in the README
infomiho 0fae11c
Drop `types` to allow `@types/` packages to be used
infomiho ac02cca
Update package.json to replace 'import' with 'default' in exports
infomiho 6ecacc3
Use `attw` as dev dep instead of through npx
infomiho 075cc77
Add build:libs command to `run` script
infomiho 1587964
Add note about adding new libs to AvailableLibs module
infomiho 279d1b4
Cleanup Auth.tsx
infomiho 38fdbe0
Update cookies import and formatting
infomiho 0bec41e
Update comment in makeWaspLib to clarify why we append the checksum
infomiho 68a4035
Update README paths
infomiho 500f574
Remove libs/ dir from Git
infomiho 2dc8399
Rename sanitizePackageNameAsNpmPackTarball to packageNameToTarballPrefix
infomiho 97f1a49
Fix typos and improve clarity in WaspLib documentation
infomiho d07b368
Improve packages install script
infomiho e4eb6dc
Update libs versioning info in the README
infomiho e27c122
Make cleanup safer in package copying scripts
infomiho 4a92a58
Update waspc README to mention the libs
infomiho f976fd3
Merge branch 'main' into templates-to-libs
infomiho 2b20ffe
Merge branch 'main' into templates-to-libs
infomiho 8221ba4
Merge branch 'main' into templates-to-libs
infomiho 5624759
Encode assumption about where the libs are located
infomiho 07b4e7b
Merge branch 'main' into templates-to-libs
infomiho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be using
./runinstead of the script in all cases?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked about this in the Discord a couple of months ago and we agreed we want to use
runin the CI. I never created a GIthub issue for it, thanks for the reminder! I'd tackle it in a separate PR.Here's the issue: #3230