fix: resolve module content duplication when module appears in multiple chunks #1367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsdoctor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
yifancong
changed the title
yifancong
force-pushed
the
fix/sourcemap-parse-tool-multi-chunk
branch
from
7da099f to
c6128ba
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes module content duplication when a module appears in multiple chunks by changing the sourcemap storage structure from concatenating all code segments to storing them separately per chunk.
Key Changes:
- Modified
sourceMapSetsdata structure to use nested Maps (module → chunk → content) instead of concatenating content - Added
chunkNameparameter tocollectSourceMapsfunction to track which chunk each code segment belongs to - Added validation to warn when chunk name is not provided
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
yifancong
force-pushed
the
fix/sourcemap-parse-tool-multi-chunk
branch
3 times, most recently
from
7b46e95 to
ec8d9d2
Compare
yifancong
commented
Oct 23, 2025
9aoy
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix: resolve module content duplication when module appears in multiple chunks
When a module is bundled by multiple chunks, the module content in sourceMapSets will be concatenated multiple times with the module codes, resulting in inaccurate module size.
Related Links