Skip to content

Conversation

shuga2704
Copy link
Contributor

Summary

Enable Rslint rule and fix lint issues:

@typescript-eslint/no-require-imports

Related links

#11761

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@shuga2704 shuga2704 requested a review from hardfist as a code owner October 19, 2025 11:56
@netlify
Copy link

netlify bot commented Oct 19, 2025

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit b2b8bf3
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68f4d1eaf1e32f0008235670

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I’d prefer not to modify the existing code for now. In @rspack/core, some require() calls are intentionally used to load certain modules on demand, which helps improve the initial startup performance.

In Rspack 2.0, we plan to make @rspack/core a pure ESM package and will re-evaluate whether it’s necessary to replace those require() calls with import().

@shuga2704
Copy link
Contributor Author

Sorry, I’d prefer not to modify the existing code for now. In @rspack/core, some require() calls are intentionally used to load certain modules on demand, which helps improve the initial startup performance.

In Rspack 2.0, we plan to make @rspack/core a pure ESM package and will re-evaluate whether it’s necessary to replace those require() calls with import().

Sure, no problem.

@shuga2704 shuga2704 closed this Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants