fix(mf): federation modules plugin hooks leak #11929
Merged
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
github-actions
bot
added
release: bug fix
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a memory leak in the federation modules plugin by implementing proper cleanup of plugin hooks. The change ensures that federation module plugin hooks are properly removed from the global hooks map when compilation cache is cleared.
- Adds a
clear_cachemethod to properly clean up federation module plugin hooks
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
📦 Binary Size-limit
🙈 Size remains the same at 47.73MB |
CodSpeed Performance ReportMerging #11929 will not alter performanceComparing Summary
|
ahabhgk
previously approved these changes
Oct 20, 2025
quininer
force-pushed
the
x/mf-leak
branch
2 times, most recently
from
edef5d0 to
0f20475
Compare
ahabhgk
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently
FEDERATION_MODULES_PLUGIN_HOOKS_MAPis not remove anywhere, I followed my previous attempt to remove it inclear_cache. but I am not sure if this behavior is correct.Related links
Checklist