fix: should allow override can_inline_use in flag dependency usage plugin #11934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
github-actions
bot
added
release: bug fix
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the flag dependency usage plugin to properly handle the can_inline_use state for export dependencies. The fix ensures that when an export cannot be inlined (due to destructuring patterns), the state is correctly set to CanInlineUse::No rather than remaining uninitialized.
Key changes:
- Added logic to explicitly set
can_inline_usetoNowhen inlining is not possible - Renamed
traverse_on_lefttotraverse_on_leaffor better semantic clarity - Added test coverage for reexported destructuring scenarios
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/rspack_plugin_javascript/src/plugin/flag_dependency_usage_plugin.rs | Added explicit setting of can_inline_use to No when can_inline is false |
| crates/rspack_core/src/exports/utils.rs | Added documentation explaining the need for HasInfo initial state in CanInlineUse enum |
| crates/rspack_plugin_javascript/src/visitors/dependency/parser/mod.rs | Renamed traverse_on_left to traverse_on_leaf for semantic clarity |
| crates/rspack_plugin_javascript/src/parser_plugin/import_parser_plugin.rs | Updated method calls from traverse_on_left to traverse_on_leaf |
| crates/rspack_plugin_javascript/src/dependency/esm/esm_import_specifier_dependency.rs | Updated method call from traverse_on_left to traverse_on_leaf |
| tests/rspack-test/configCases/inline-enum/basic/rspack.config.js | Added ES2022 target configuration for test |
| tests/rspack-test/configCases/inline-enum/basic/re-export.reexprt-destructuring.ts | Added new test file for reexported destructuring scenario |
| tests/rspack-test/configCases/inline-enum/basic/enum.reexport-destructuring.ts | Added enum definition for reexport destructuring test |
| tests/rspack-test/configCases/inline-enum/basic/index.js | Added test case and fixed variable naming from "destructing" to "destructuring" |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tests/rspack-test/configCases/inline-enum/basic/re-export.reexprt-destructuring.ts
Show resolved
Hide resolved
📦 Binary Size-limit
🙈 Size remains the same at 47.73MB |
CodSpeed Performance ReportMerging #11934 will not alter performanceComparing Summary
|
SyMind
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Should allow override can_inline_use in flag dependency usage plugin
Related links
Checklist