perf: improve source map parse from json #11950
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
github-actions
bot
added
release: performance
There was a problem hiding this comment.
Pull Request Overview
This PR improves performance when parsing source maps from JSON by updating the rspack_sources dependency and adapting the codebase to use a new iterator-based API instead of the previous collection-based approach.
Key changes:
- Updates
rspack_sourcesdependency to use a git revision with performance improvements - Refactors code to use iterator methods (
sources(),get_source_content()) instead of collection methods (sources().iter(),sources_content().get()) - Changes
SourceMap::from_slice()calls toSourceMap::from_json()for more efficient parsing
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Updates rspack_sources dependency to git revision with performance improvements |
| crates/rspack_plugin_rsdoctor/src/module_graph.rs | Refactors to use iterator-based source access methods |
| crates/rspack_plugin_devtool/src/source_map_dev_tool_plugin.rs | Removes unnecessary .iter() calls on sources iterator |
| crates/rspack_plugin_devtool/src/eval_source_map_dev_tool_plugin.rs | Removes .iter() call for sources iteration |
| crates/rspack_loader_swc/src/lib.rs | Removes .iter() call for sources iteration |
| crates/rspack_core/src/utils/extract_source_map.rs | Changes sources collection to use iterator with explicit mapping |
| crates/rspack_cacheable/src/with/as_preset/rspack_sources/mod.rs | Removes unnecessary reference in conditional binding |
| crates/rspack_binding_api/src/swc.rs | Replaces JSON serialization with to_json() method |
| crates/rspack_binding_api/src/source.rs | Replaces from_slice() with more efficient from_json() method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| ropey = { version = "1.6.1", default-features = false } | ||
| rspack_resolver = { features = ["package_json_raw_json_api", "yarn_pnp"], version = "0.6.3", default-features = false } | ||
| rspack_sources = { version = "=0.4.11", default-features = false } | ||
| rspack_sources = { git = "https://github.com/SyMind/rspack-sources.git", rev = "1cbefbd08acf0225a9eae9bb4e01084b6886f650", default-features = false } |
There was a problem hiding this comment.
Using a git dependency with a specific commit instead of a versioned release makes the build less reproducible and harder to audit. Consider publishing this change as a new version of rspack_sources (e.g., 0.4.12) and using a semver dependency instead.
Suggested change
| rspack_sources = { git = "https://github.com/SyMind/rspack-sources.git", rev = "1cbefbd08acf0225a9eae9bb4e01084b6886f650", default-features = false } | |
| rspack_sources = { version = "0.4.12", default-features = false } |
📦 Binary Size-limit
❌ Size increased by 13.88KB from 47.82MB to 47.83MB (⬆️0.03%) |
CodSpeed Performance ReportMerging #11950 will not alter performanceComparing Summary
|
SyMind
force-pushed
the
perf-source-map-json-parse
branch
2 times, most recently
from
7b5e493 to
29e9cbd
Compare
|
📝 Benchmark detail: Open
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related links
Checklist