test: should not panic for mf sharing asset modules #12003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
team
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a panic that occurs when Module Federation shares asset modules. The fix refactors the logic in AssetParserAndGenerator::get_types to properly handle source type determination when assets are shared between federated modules.
Key changes:
- Refactored conditional logic in
get_typesmethod to avoid panic scenarios - Added test case to verify asset modules work correctly with Module Federation sharing
- Fixed debug configuration path to use generic "node" instead of absolute path
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/rspack_plugin_asset/src/lib.rs | Refactored get_types method logic to eliminate panic conditions when handling shared asset modules |
| tests/rspack-test/configCases/assets/asset-shared-by-mf/test.js | Added test to verify asset imports work when shared via Module Federation |
| tests/rspack-test/configCases/assets/asset-shared-by-mf/rspack.config.js | Test configuration for Module Federation with shared assets |
| tests/rspack-test/configCases/assets/asset-shared-by-mf/index.js | Test entry point that dynamically imports the test module |
| scripts/debug/launch.mjs | Changed node program path from absolute to relative for portability |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ahabhgk
requested review from
LingyuCoder
and removed request for
stormslowly
📦 Binary Size-limit
🙈 Size remains the same at 47.85MB |
CodSpeed Performance ReportMerging #12003 will not alter performanceComparing Summary
|
SyMind
previously approved these changes
Oct 27, 2025
ahabhgk
force-pushed
the
fix-share-asset-mf
branch
from
ddb93f1 to
c39ad72
Compare
ahabhgk
changed the title
github-actions
bot
removed
the
release: bug fix
SyMind
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
test coverage for #11861, which should be fixed by #11993
close #11861
Related links
Checklist