Skip to content

Conversation

@hardfist
Copy link
Contributor

@hardfist hardfist commented Nov 13, 2025

Summary

add collect_build_module_graph_effects artifact and merge async_module_artifacts and dependencies_diagnostics into it

Followup:
change &mut Compilation into &Compilation for collect_build_module_graph_effects

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Nov 13, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 91e1e86
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/69256137690d6f000840410a

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Nov 13, 2025
@hardfist hardfist force-pushed the yj/add-effects-artifact branch 2 times, most recently from 6967a9d to 6c60f68 Compare November 14, 2025 08:43
@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2025

📦 Binary Size-limit

Comparing 91e1e86 to refactor: render runtime globals by runtime template (#12272) by harpsealjs

❌ Size increased by 8.88KB from 47.65MB to 47.66MB (⬆️0.02%)

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 14, 2025

CodSpeed Performance Report

Merging #12191 will not alter performance

Comparing yj/add-effects-artifact (91e1e86) with main (cb2a294)

Summary

✅ 17 untouched

@hardfist hardfist force-pushed the yj/add-effects-artifact branch from 6c60f68 to f5bce23 Compare November 14, 2025 09:31
@hardfist hardfist force-pushed the yj/add-effects-artifact branch 2 times, most recently from 13c5c3d to b9767c3 Compare November 25, 2025 06:31
@hardfist hardfist force-pushed the yj/add-effects-artifact branch from b9767c3 to 91e1e86 Compare November 25, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants